Revert of Do not hide shadow underlay for max/fullscreen state even if the client disables the ...

Revert of Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow. (patchset #3 id:40001 of https://codereview.chromium.org/2820493004/ )

Reason for revert:
This change broke basic WM interaction of ARC and caused browser crash. https://crbug.com/713560

Original issue's description:
> Do not hide shadow underlay for max/fullscreen state even if the client disables the shadow.
> 
> During the state transition, ARC preserves windows being deleted,
> however the main window is deleted (thus, window frame is empty) which disables the shadow.
> 
> BUG=711514
> TEST=covered by unit tests.
>  manual. Instal & start "Clash Royal", then F4 to toggle fullscreen.
> 
> Review-Url: https://codereview.chromium.org/2820493004
> Cr-Commit-Position: refs/heads/master@{#464819}
> Committed: https://chromium.googlesource.com/chromium/src/+/ae72f92d7caba6d32ba2a11f32943f29af15c3d8

TBR=reveman@chromium.org,oshima@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=713560
Review-Url: https://codereview.chromium.org/2827233002
Cr-Commit-Position: refs/heads/master@{#466063}
Committed: https://chromium.googlesource.com/chromium/src/+/b650cb773adbf72f3f731e0bc56e22d55c521391

[Shuhei Takahashi, 2017-04-20 07:18:36]

The CQ bit was checked by nya@chromium.org

[Shuhei Takahashi, 2017-04-20 07:18:36]

Created Revert of Do not hide shadow underlay for max/fullscreen state even if
the client disables the shadow.

[Shuhei Takahashi, 2017-04-20 07:20:06]

Description was changed from

==========
Revert of Do not hide shadow underlay for max/fullscreen state even if the
client disables the shadow. (patchset #3 id:40001 of
https://codereview.chromium.org/2820493004/ )

Reason for revert:
This change broke basic WM interaction of ARC and caused browser crash.
https://crbug.com/713560

Original issue's description:
> Do not hide shadow underlay for max/fullscreen state even if the client
disables the shadow.
> 
> During the state transition, ARC preserves windows being deleted,
> however the main window is deleted (thus, window frame is empty) which
disables the shadow.
> 
> BUG=711514
> TEST=covered by unit tests.
>  manual. Instal & start "Clash Royal", then F4 to toggle fullscreen.
> 
> Review-Url: https://codereview.chromium.org/2820493004
> Cr-Commit-Position: refs/heads/master@{#464819}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ae72f92d7caba6d32ba2a11f3294...

TBR=reveman@chromium.org,oshima@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=711514
==========

to

==========
Revert of Do not hide shadow underlay for max/fullscreen state even if the
client disables the shadow. (patchset #3 id:40001 of
https://codereview.chromium.org/2820493004/ )

Reason for revert:
This change broke basic WM interaction of ARC and caused browser crash.
https://crbug.com/713560

Original issue's description:
> Do not hide shadow underlay for max/fullscreen state even if the client
disables the shadow.
> 
> During the state transition, ARC preserves windows being deleted,
> however the main window is deleted (thus, window frame is empty) which
disables the shadow.
> 
> BUG=711514
> TEST=covered by unit tests.
>  manual. Instal & start "Clash Royal", then F4 to toggle fullscreen.
> 
> Review-Url: https://codereview.chromium.org/2820493004
> Cr-Commit-Position: refs/heads/master@{#464819}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ae72f92d7caba6d32ba2a11f3294...

TBR=reveman@chromium.org,oshima@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=711514
BUG=713560
==========

[commit-bot: I haz the power, 2017-04-20 07:21:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 07:21:58]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Shuhei Takahashi, 2017-04-20 07:36:50]

The CQ bit was checked by nya@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 07:37:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Shuhei Takahashi, 2017-04-20 07:41:18]

reveman: PTAL for OWNER
oshima: FYI as the original author
hidehiko, victorhsieh: FYI as ARC constables

I had to manually resolve the merge conflict with
https://codereview.chromium.org/2816423003/

Reviewers, please verify the order of SetBounds() and Show() is correct after
resolving merge conflicts.

[Shuhei Takahashi, 2017-04-20 07:41:50]

Description was changed from

==========
Revert of Do not hide shadow underlay for max/fullscreen state even if the
client disables the shadow. (patchset #3 id:40001 of
https://codereview.chromium.org/2820493004/ )

Reason for revert:
This change broke basic WM interaction of ARC and caused browser crash.
https://crbug.com/713560

Original issue's description:
> Do not hide shadow underlay for max/fullscreen state even if the client
disables the shadow.
> 
> During the state transition, ARC preserves windows being deleted,
> however the main window is deleted (thus, window frame is empty) which
disables the shadow.
> 
> BUG=711514
> TEST=covered by unit tests.
>  manual. Instal & start "Clash Royal", then F4 to toggle fullscreen.
> 
> Review-Url: https://codereview.chromium.org/2820493004
> Cr-Commit-Position: refs/heads/master@{#464819}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ae72f92d7caba6d32ba2a11f3294...

TBR=reveman@chromium.org,oshima@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=711514
BUG=713560
==========

to

==========
Revert of Do not hide shadow underlay for max/fullscreen state even if the
client disables the shadow. (patchset #3 id:40001 of
https://codereview.chromium.org/2820493004/ )

Reason for revert:
This change broke basic WM interaction of ARC and caused browser crash.
https://crbug.com/713560

Original issue's description:
> Do not hide shadow underlay for max/fullscreen state even if the client
disables the shadow.
> 
> During the state transition, ARC preserves windows being deleted,
> however the main window is deleted (thus, window frame is empty) which
disables the shadow.
> 
> BUG=711514
> TEST=covered by unit tests.
>  manual. Instal & start "Clash Royal", then F4 to toggle fullscreen.
> 
> Review-Url: https://codereview.chromium.org/2820493004
> Cr-Commit-Position: refs/heads/master@{#464819}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ae72f92d7caba6d32ba2a11f3294...

TBR=reveman@chromium.org,oshima@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=713560
==========

[commit-bot: I haz the power, 2017-04-20 08:06:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 08:06:12]

Dry run: This issue passed the CQ dry run.

[Shuhei Takahashi, 2017-04-20 08:29:06]

Verified this revert fixes the issue on Chrome OS R60-9477.0.0.

[victorhsieh0, 2017-04-20 17:50:35]

The CQ bit was checked by victorhsieh@google.com

[commit-bot: I haz the power, 2017-04-20 17:51:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 17:55:26]

CQ is committing da patch.

Bot data: {"patchset_id": 70001, "attempt_start_ts": 1492710635470660,
"parent_rev": "576dc51777e5447b043f45eb72bc54c9a7acf222", "commit_rev":
"b650cb773adbf72f3f731e0bc56e22d55c521391"}

[commit-bot: I haz the power, 2017-04-20 17:55:37]

Description was changed from

==========
Revert of Do not hide shadow underlay for max/fullscreen state even if the
client disables the shadow. (patchset #3 id:40001 of
https://codereview.chromium.org/2820493004/ )

Reason for revert:
This change broke basic WM interaction of ARC and caused browser crash.
https://crbug.com/713560

Original issue's description:
> Do not hide shadow underlay for max/fullscreen state even if the client
disables the shadow.
> 
> During the state transition, ARC preserves windows being deleted,
> however the main window is deleted (thus, window frame is empty) which
disables the shadow.
> 
> BUG=711514
> TEST=covered by unit tests.
>  manual. Instal & start "Clash Royal", then F4 to toggle fullscreen.
> 
> Review-Url: https://codereview.chromium.org/2820493004
> Cr-Commit-Position: refs/heads/master@{#464819}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ae72f92d7caba6d32ba2a11f3294...

TBR=reveman@chromium.org,oshima@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=713560
==========

to

==========
Revert of Do not hide shadow underlay for max/fullscreen state even if the
client disables the shadow. (patchset #3 id:40001 of
https://codereview.chromium.org/2820493004/ )

Reason for revert:
This change broke basic WM interaction of ARC and caused browser crash.
https://crbug.com/713560

Original issue's description:
> Do not hide shadow underlay for max/fullscreen state even if the client
disables the shadow.
> 
> During the state transition, ARC preserves windows being deleted,
> however the main window is deleted (thus, window frame is empty) which
disables the shadow.
> 
> BUG=711514
> TEST=covered by unit tests.
>  manual. Instal & start "Clash Royal", then F4 to toggle fullscreen.
> 
> Review-Url: https://codereview.chromium.org/2820493004
> Cr-Commit-Position: refs/heads/master@{#464819}
> Committed:
https://chromium.googlesource.com/chromium/src/+/ae72f92d7caba6d32ba2a11f3294...

TBR=reveman@chromium.org,oshima@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=713560

Review-Url: https://codereview.chromium.org/2827233002
Cr-Commit-Position: refs/heads/master@{#466063}
Committed:
https://chromium.googlesource.com/chromium/src/+/b650cb773adbf72f3f731e0bc56e...
==========

[commit-bot: I haz the power, 2017-04-20 17:55:38]

Committed patchset #2 (id:70001) as
https://chromium.googlesource.com/chromium/src/+/b650cb773adbf72f3f731e0bc56e...