Add TaskScheduler::Create and TaskScheduler::CreateAndStartWithDefaultParams.

Add TaskScheduler::Create and TaskScheduler::CreateAndStartWithDefaultParams.

Processes that need to initialize task scheduler with custom params
and processes that need to create and start task scheduler in separate
steps should use TaskScheduler::Create.

Processes that need a task scheduler but don't need custom
initialization params and are fine with creating and starting the
task scheduler in one step (i.e. don't need a period during which
tasks can be posted to task scheduler without running) should
use TaskScheduler::CreateAndStartWithDefaultParams.

BUG=690706
Review-Url: https://codereview.chromium.org/2836033002
Cr-Commit-Position: refs/heads/master@{#467159}
Committed: https://chromium.googlesource.com/chromium/src/+/43ec6dfaa0c7df6c01fc05649593808bbe5e051b

[fdoray, 2017-04-24 12:54:57]

The CQ bit was checked by fdoray@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 12:55:11]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 16:17:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 16:17:33]

Dry run: This issue passed the CQ dry run.

[fdoray, 2017-04-24 17:05:58]

fdoray@chromium.org changed reviewers:
+ gab@chromium.org, robliao@chromium.org

[fdoray, 2017-04-24 17:05:59]

PTAL

[robliao, 2017-04-24 22:37:27]

lgtm

https://codereview.chromium.org/2836033002/diff/1/base/task_scheduler/task_sc...
File base/task_scheduler/task_scheduler.h (right):

https://codereview.chromium.org/2836033002/diff/1/base/task_scheduler/task_sc...
base/task_scheduler/task_scheduler.h:138: // CreateAndStartWithDefaultParams(),
Create(), and SetInstance() register a
Discuss when one would use Create vs CreateAndStartWithDefaultParams.

https://codereview.chromium.org/2836033002/diff/1/base/task_scheduler/task_sc...
base/task_scheduler/task_scheduler.h:158: // Creates a task scheduler. |name| is
used to label threads and histograms.
Creates a ready to start task scheduler.

[gab, 2017-04-25 15:23:40]

lgtm w/ comments

https://codereview.chromium.org/2836033002/diff/20001/base/task_scheduler/tas...
File base/task_scheduler/task_scheduler.h (right):

https://codereview.chromium.org/2836033002/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_scheduler.h:154: // Deprecated.
// TODO(fdoray): Redirect callers to CreateAndStartWithDefaultParams().

https://codereview.chromium.org/2836033002/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_scheduler.h:166: // Deprecated.
Mention what to use instead.

[fdoray, 2017-04-25 21:56:11]

https://codereview.chromium.org/2836033002/diff/1/base/task_scheduler/task_sc...
File base/task_scheduler/task_scheduler.h (right):

https://codereview.chromium.org/2836033002/diff/1/base/task_scheduler/task_sc...
base/task_scheduler/task_scheduler.h:138: // CreateAndStartWithDefaultParams(),
Create(), and SetInstance() register a
On 2017/04/24 22:37:27, robliao wrote:
> Discuss when one would use Create vs CreateAndStartWithDefaultParams.

Done.

https://codereview.chromium.org/2836033002/diff/1/base/task_scheduler/task_sc...
base/task_scheduler/task_scheduler.h:158: // Creates a task scheduler. |name| is
used to label threads and histograms.
On 2017/04/24 22:37:27, robliao wrote:
> Creates a ready to start task scheduler.

Done.

https://codereview.chromium.org/2836033002/diff/20001/base/task_scheduler/tas...
File base/task_scheduler/task_scheduler.h (right):

https://codereview.chromium.org/2836033002/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_scheduler.h:154: // Deprecated.
On 2017/04/25 15:23:40, gab wrote:
> // TODO(fdoray): Redirect callers to CreateAndStartWithDefaultParams().

Done.

https://codereview.chromium.org/2836033002/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_scheduler.h:166: // Deprecated.
On 2017/04/25 15:23:40, gab wrote:
> Mention what to use instead.

Done.

[fdoray, 2017-04-25 21:56:11]

https://codereview.chromium.org/2836033002/diff/1/base/task_scheduler/task_sc...
File base/task_scheduler/task_scheduler.h (right):

https://codereview.chromium.org/2836033002/diff/1/base/task_scheduler/task_sc...
base/task_scheduler/task_scheduler.h:138: // CreateAndStartWithDefaultParams(),
Create(), and SetInstance() register a
On 2017/04/24 22:37:27, robliao wrote:
> Discuss when one would use Create vs CreateAndStartWithDefaultParams.

Done.

https://codereview.chromium.org/2836033002/diff/1/base/task_scheduler/task_sc...
base/task_scheduler/task_scheduler.h:158: // Creates a task scheduler. |name| is
used to label threads and histograms.
On 2017/04/24 22:37:27, robliao wrote:
> Creates a ready to start task scheduler.

Done.

https://codereview.chromium.org/2836033002/diff/20001/base/task_scheduler/tas...
File base/task_scheduler/task_scheduler.h (right):

https://codereview.chromium.org/2836033002/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_scheduler.h:154: // Deprecated.
On 2017/04/25 15:23:40, gab wrote:
> // TODO(fdoray): Redirect callers to CreateAndStartWithDefaultParams().

Done.

https://codereview.chromium.org/2836033002/diff/20001/base/task_scheduler/tas...
base/task_scheduler/task_scheduler.h:166: // Deprecated.
On 2017/04/25 15:23:40, gab wrote:
> Mention what to use instead.

Done.

[fdoray, 2017-04-25 21:56:21]

The CQ bit was checked by fdoray@chromium.org

[fdoray, 2017-04-25 21:56:21]

The patchset sent to the CQ was uploaded after l-g-t-m from
robliao@chromium.org, gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2836033002/#ps60001
(title: "self-review")

[commit-bot: I haz the power, 2017-04-25 21:56:41]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 23:16:15]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493157381060280,
"parent_rev": "d9b87d2672130154bc29125d1ff3b75144e51108", "commit_rev":
"43ec6dfaa0c7df6c01fc05649593808bbe5e051b"}

[commit-bot: I haz the power, 2017-04-25 23:16:26]

Description was changed from

==========
Add TaskScheduler::Create and TaskScheduler::CreateAndStartWithDefaultParams.

Processes that need to initialize task scheduler with custom params
and processes that need to create and start task scheduler in separate
steps should use TaskScheduler::Create.

Processes that need a task scheduler but don't need custom
initialization params and are fine with creating and starting the
task scheduler in one step (i.e. don't need a period during which
tasks can be posted to task scheduler without running) should
use TaskScheduler::CreateAndStartWithDefaultParams.

BUG=690706
==========

to

==========
Add TaskScheduler::Create and TaskScheduler::CreateAndStartWithDefaultParams.

Processes that need to initialize task scheduler with custom params
and processes that need to create and start task scheduler in separate
steps should use TaskScheduler::Create.

Processes that need a task scheduler but don't need custom
initialization params and are fine with creating and starting the
task scheduler in one step (i.e. don't need a period during which
tasks can be posted to task scheduler without running) should
use TaskScheduler::CreateAndStartWithDefaultParams.

BUG=690706

Review-Url: https://codereview.chromium.org/2836033002
Cr-Commit-Position: refs/heads/master@{#467159}
Committed:
https://chromium.googlesource.com/chromium/src/+/43ec6dfaa0c7df6c01fc05649593...
==========

[commit-bot: I haz the power, 2017-04-25 23:16:27]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/43ec6dfaa0c7df6c01fc05649593...