Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1621)

Unified Diff: base/task_scheduler/task_scheduler.cc

Issue 2836033002: Add TaskScheduler::Create and TaskScheduler::CreateAndStartWithDefaultParams. (Closed)
Patch Set: self-review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/task_scheduler/task_scheduler.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/task_scheduler/task_scheduler.cc
diff --git a/base/task_scheduler/task_scheduler.cc b/base/task_scheduler/task_scheduler.cc
index c1eb4323c9fe10724c8366bf1369e9aa67d7546f..80359c307c7ae8f635c72297840eeb157ffcfe50 100644
--- a/base/task_scheduler/task_scheduler.cc
+++ b/base/task_scheduler/task_scheduler.cc
@@ -39,7 +39,7 @@ TaskScheduler::InitParams::~InitParams() = default;
#if !defined(OS_NACL)
// static
-void TaskScheduler::CreateAndSetSimpleTaskScheduler(StringPiece name) {
+void TaskScheduler::CreateAndStartWithDefaultParams(StringPiece name) {
using StandbyThreadPolicy = SchedulerWorkerPoolParams::StandbyThreadPolicy;
// Values were chosen so that:
@@ -54,22 +54,32 @@ void TaskScheduler::CreateAndSetSimpleTaskScheduler(StringPiece name) {
constexpr TimeDelta kSuggestedReclaimTime = TimeDelta::FromSeconds(30);
- CreateAndSetDefaultTaskScheduler(
- name, {{StandbyThreadPolicy::LAZY, kBackgroundMaxThreads,
- kSuggestedReclaimTime},
- {StandbyThreadPolicy::LAZY, kBackgroundBlockingMaxThreads,
- kSuggestedReclaimTime},
- {StandbyThreadPolicy::LAZY, kForegroundMaxThreads,
- kSuggestedReclaimTime},
- {StandbyThreadPolicy::LAZY, kForegroundBlockingMaxThreads,
- kSuggestedReclaimTime}});
+ Create(name);
+ GetInstance()->Start(
+ {{StandbyThreadPolicy::LAZY, kBackgroundMaxThreads,
+ kSuggestedReclaimTime},
+ {StandbyThreadPolicy::LAZY, kBackgroundBlockingMaxThreads,
+ kSuggestedReclaimTime},
+ {StandbyThreadPolicy::LAZY, kForegroundMaxThreads,
+ kSuggestedReclaimTime},
+ {StandbyThreadPolicy::LAZY, kForegroundBlockingMaxThreads,
+ kSuggestedReclaimTime}});
+}
+
+// static
+void TaskScheduler::CreateAndSetSimpleTaskScheduler(StringPiece name) {
+ CreateAndStartWithDefaultParams(name);
}
#endif // !defined(OS_NACL)
+void TaskScheduler::Create(StringPiece name) {
+ SetInstance(MakeUnique<internal::TaskSchedulerImpl>(name));
+}
+
void TaskScheduler::CreateAndSetDefaultTaskScheduler(
StringPiece name,
const InitParams& init_params) {
- SetInstance(MakeUnique<internal::TaskSchedulerImpl>(name));
+ Create(name);
GetInstance()->Start(init_params);
}
« no previous file with comments | « base/task_scheduler/task_scheduler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698