Add TaskScheduler::Create and TaskScheduler::CreateAndStartWithDefaultParams.

base/task_scheduler/task_scheduler.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BASE_TASK_SCHEDULER_TASK_SCHEDULER_H_
 #define BASE_TASK_SCHEDULER_TASK_SCHEDULER_H_
 
 #include <memory>
 #include <vector>
 
@@ skipping 117 matching lines @@
   // Does not wait for delayed tasks. Waits for undelayed tasks posted from
   // other threads during the call. Returns immediately when shutdown completes.
   virtual void FlushForTesting() = 0;
 
   // Joins all threads. Tasks that are already running are allowed to complete
   // their execution. This can only be called once. Using this task scheduler
   // instance to create task runners or post tasks is not permitted during or
   // after this call.
   virtual void JoinForTesting() = 0;
 
-  // CreateAndSetSimpleTaskScheduler(), CreateAndSetDefaultTaskScheduler(), and
-  // SetInstance() register a TaskScheduler to handle tasks posted through the
-  // post_task.h API for this process. The registered TaskScheduler will only be
-  // deleted when a new TaskScheduler is registered and is leaked on shutdown.
-  // The methods must not be called when TaskRunners created by the previous
-  // TaskScheduler are still alive. The methods are not thread-safe; proper
-  // synchronization is required to use the post_task.h API after registering a
-  // new TaskScheduler.
+// CreateAndStartWithDefaultParams(), Create(), and SetInstance() register a

[robliao, 2017/04/24 22:37:27]

Discuss when one would use Create vs CreateAndStartWithDefaultParams.

[fdoray, 2017/04/25 21:56:11]

Done.

+// TaskScheduler to handle tasks posted through the post_task.h API for this
+// process. The registered TaskScheduler will only be deleted when a new
+// TaskScheduler is registered and is leaked on shutdown. The methods must not
+// be called when TaskRunners created by the previous TaskScheduler are still
+// alive. The methods are not thread-safe; proper synchronization is required to
+// use the post_task.h API after registering a new TaskScheduler.
 
 #if !defined(OS_NACL)
-  // Creates and sets a task scheduler using default params. |name| is used to
+  // Creates and starts a task scheduler using default params. |name| is used to
   // label threads and histograms. It should identify the component that calls
-  // this. CHECKs on failure. For tests, prefer base::test::ScopedTaskScheduler
-  // (ensures isolation).
+  // this. Start() is called by this method; it is invalid to call it again
+  // afterwards. CHECKs on failure. For tests, prefer
+  // base::test::ScopedTaskEnvironment (ensures isolation).
+  static void CreateAndStartWithDefaultParams(StringPiece name);
+
+  // Deprecated.
   static void CreateAndSetSimpleTaskScheduler(StringPiece name);
 #endif  // !defined(OS_NACL)
 
-  // Creates and sets a task scheduler using custom params. |name| is used to
-  // label threads and histograms. It should identify the component that creates
-  // the TaskScheduler. |init_params| is used to initialize the worker pools.
-  // CHECKs on failure. For tests, prefer base::test::ScopedTaskScheduler
-  // (ensures isolation).
+  // Creates a task scheduler. |name| is used to label threads and histograms.

[robliao, 2017/04/24 22:37:27]

Creates a ready to start task scheduler.

[fdoray, 2017/04/25 21:56:10]

Done.

+  // It should identify the component that creates the TaskScheduler. The task
+  // scheduler doesn't create threads until Start() is called on
+  // TaskScheduler::GetInstance(). Tasks can be posted before Start() is called,
+  // but they don't run until Start() is called. For tests, prefer
+  // base::test::ScopedTaskEnvironment (ensures isolation).
+  static void Create(StringPiece name);
+
+  // Deprecated.
   static void CreateAndSetDefaultTaskScheduler(StringPiece name,
                                                const InitParams& init_params);
 
   // Registers |task_scheduler| to handle tasks posted through the post_task.h
   // API for this process. For tests, prefer base::test::ScopedTaskScheduler
   // (ensures isolation).
   static void SetInstance(std::unique_ptr<TaskScheduler> task_scheduler);
 
   // Retrieve the TaskScheduler set via SetInstance() or
   // CreateAndSet(Simple|Default)TaskScheduler(). This should be used very
@@ skipping 19 matching lines @@
   // each process n/GetMaxConcurrentTasksWithTraitsDeprecated() items.
   //
   // TODO(fdoray): Remove this method. https://crbug.com/687264
   virtual int GetMaxConcurrentTasksWithTraitsDeprecated(
       const TaskTraits& traits) const = 0;
 };
 
 }  // namespace base
 
 #endif  // BASE_TASK_SCHEDULER_TASK_SCHEDULER_H_