Reject frames with invalid BeginFrameAck in CompositorFrameSinkSupport

Reject frames with invalid BeginFrameAck in CompositorFrameSinkSupport

Currently we fix the frame's BeginFrameAck in CompositorFrameSinkSupport
if it's invalid and print an error message. There is no reason to do this
other than the fact that tests are clumsy and send invalid frames. This
CL fixes the tests and rejects invalid BeginFrameAcks in CFSS.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2835393003
Cr-Commit-Position: refs/heads/master@{#467036}
Committed: https://chromium.googlesource.com/chromium/src/+/b504122f5dc941bc7f73ed126bb42ab50a152cc4

[Saman Sami, 2017-04-25 14:28:10]

Description was changed from

==========
Test
==========

to

==========
Test
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-04-25 14:32:55]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 14:33:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-04-25 14:37:49]

Description was changed from

==========
Test
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Reject frames with invalid BeginFrameAck in CompositorFrameSinkSupport

Currently we fix the frame's BeginFrameAck in CompositorFrameSinkSupport
if it's invalid and print an error message. There is no reason to do this
other than the fact that tests are clumsy and send invalid frames. This
CL fixes the tests and rejects invalid BeginFrameAcks in CFSS.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Saman Sami, 2017-04-25 14:40:00]

The CQ bit was checked by samans@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-25 14:40:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Saman Sami, 2017-04-25 14:40:49]

samans@chromium.org changed reviewers:
+ danakj@chromium.org

[Saman Sami, 2017-04-25 14:41:51]

PTAL

[danakj, 2017-04-25 15:24:36]

LGTM

https://codereview.chromium.org/2835393003/diff/20001/cc/test/compositor_fram...
File cc/test/compositor_frame_helpers.h (right):

https://codereview.chromium.org/2835393003/diff/20001/cc/test/compositor_fram...
cc/test/compositor_frame_helpers.h:12: namespace test {
Didn't realize we had other cc::test::FreeFunctions like this but we do,
interesting.

[Saman Sami, 2017-04-25 16:00:54]

The CQ bit was unchecked by samans@chromium.org

[Saman Sami, 2017-04-25 16:01:04]

The CQ bit was checked by samans@chromium.org

[commit-bot: I haz the power, 2017-04-25 16:01:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-25 17:34:27]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493136064464250,
"parent_rev": "a8416d28ba0e17d3b6cc8b1e328bf1bea8210891", "commit_rev":
"b504122f5dc941bc7f73ed126bb42ab50a152cc4"}

[commit-bot: I haz the power, 2017-04-25 17:34:35]

Description was changed from

==========
Reject frames with invalid BeginFrameAck in CompositorFrameSinkSupport

Currently we fix the frame's BeginFrameAck in CompositorFrameSinkSupport
if it's invalid and print an error message. There is no reason to do this
other than the fact that tests are clumsy and send invalid frames. This
CL fixes the tests and rejects invalid BeginFrameAcks in CFSS.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Reject frames with invalid BeginFrameAck in CompositorFrameSinkSupport

Currently we fix the frame's BeginFrameAck in CompositorFrameSinkSupport
if it's invalid and print an error message. There is no reason to do this
other than the fact that tests are clumsy and send invalid frames. This
CL fixes the tests and rejects invalid BeginFrameAcks in CFSS.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2835393003
Cr-Commit-Position: refs/heads/master@{#467036}
Committed:
https://chromium.googlesource.com/chromium/src/+/b504122f5dc941bc7f73ed126bb4...
==========

[commit-bot: I haz the power, 2017-04-25 17:34:36]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/b504122f5dc941bc7f73ed126bb4...