Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: cc/surfaces/compositor_frame_sink_support.cc

Issue 2835393003: Reject frames with invalid BeginFrameAck in CompositorFrameSinkSupport (Closed)
Patch Set: Fixed header Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/compositor_frame_sink_support.cc
diff --git a/cc/surfaces/compositor_frame_sink_support.cc b/cc/surfaces/compositor_frame_sink_support.cc
index 7fc9e6556d46ce13067d902aa23a44019747c27e..d85a331191a65ba294c00c67c30c47f3f880c512 100644
--- a/cc/surfaces/compositor_frame_sink_support.cc
+++ b/cc/surfaces/compositor_frame_sink_support.cc
@@ -125,13 +125,9 @@ void CompositorFrameSinkSupport::SubmitCompositorFrame(
DCHECK(surface_factory_);
++ack_pending_count_;
- if (frame.metadata.begin_frame_ack.sequence_number <
- BeginFrameArgs::kStartingFrameNumber) {
- DLOG(ERROR) << "Received CompositorFrame with invalid BeginFrameAck.";
- frame.metadata.begin_frame_ack.source_id = BeginFrameArgs::kManualSourceId;
- frame.metadata.begin_frame_ack.sequence_number =
- BeginFrameArgs::kStartingFrameNumber;
- }
+ DCHECK_GE(frame.metadata.begin_frame_ack.sequence_number,
+ BeginFrameArgs::kStartingFrameNumber);
+
// |has_damage| is not transmitted.
frame.metadata.begin_frame_ack.has_damage = true;
« no previous file with comments | « cc/BUILD.gn ('k') | cc/surfaces/display_unittest.cc » ('j') | cc/test/compositor_frame_helpers.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698