Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3053)

Unified Diff: cc/surfaces/surfaces_pixeltest.cc

Issue 2835393003: Reject frames with invalid BeginFrameAck in CompositorFrameSinkSupport (Closed)
Patch Set: Fixed header Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: cc/surfaces/surfaces_pixeltest.cc
diff --git a/cc/surfaces/surfaces_pixeltest.cc b/cc/surfaces/surfaces_pixeltest.cc
index 8ba74396c466c8f2c2d34e1b26a0c1fe9af0cb76..36f1ba91f1a5ca32a68c2b8d27f5e479ce5ba413 100644
--- a/cc/surfaces/surfaces_pixeltest.cc
+++ b/cc/surfaces/surfaces_pixeltest.cc
@@ -11,6 +11,7 @@
#include "cc/surfaces/surface.h"
#include "cc/surfaces/surface_aggregator.h"
#include "cc/surfaces/surface_manager.h"
+#include "cc/test/compositor_frame_helpers.h"
#include "cc/test/pixel_comparator.h"
#include "cc/test/pixel_test.h"
#include "testing/gtest/include/gtest/gtest.h"
@@ -82,8 +83,7 @@ TEST_F(SurfacesPixelTest, DrawSimpleFrame) {
SK_ColorGREEN,
force_anti_aliasing_off);
-
- CompositorFrame root_frame;
+ CompositorFrame root_frame = test::MakeCompositorFrame();
root_frame.render_pass_list.push_back(std::move(pass));
LocalSurfaceId root_local_surface_id = allocator_.GenerateId();
@@ -140,7 +140,7 @@ TEST_F(SurfacesPixelTest, DrawSimpleAggregatedFrame) {
SK_ColorYELLOW,
force_anti_aliasing_off);
- CompositorFrame root_frame;
+ CompositorFrame root_frame = test::MakeCompositorFrame();
root_frame.render_pass_list.push_back(std::move(pass));
support_->SubmitCompositorFrame(root_local_surface_id,
@@ -165,7 +165,7 @@ TEST_F(SurfacesPixelTest, DrawSimpleAggregatedFrame) {
SK_ColorBLUE,
force_anti_aliasing_off);
- CompositorFrame child_frame;
+ CompositorFrame child_frame = test::MakeCompositorFrame();
child_frame.render_pass_list.push_back(std::move(pass));
child_support->SubmitCompositorFrame(child_local_surface_id,
@@ -240,7 +240,7 @@ TEST_F(SurfacesPixelTest, DrawAggregatedFrameWithSurfaceTransforms) {
right_child_id, SurfaceDrawQuadType::PRIMARY,
nullptr);
- CompositorFrame root_frame;
+ CompositorFrame root_frame = test::MakeCompositorFrame();
root_frame.render_pass_list.push_back(std::move(pass));
support_->SubmitCompositorFrame(root_local_surface_id,
@@ -273,7 +273,7 @@ TEST_F(SurfacesPixelTest, DrawAggregatedFrameWithSurfaceTransforms) {
SK_ColorBLUE,
force_anti_aliasing_off);
- CompositorFrame child_frame;
+ CompositorFrame child_frame = test::MakeCompositorFrame();
child_frame.render_pass_list.push_back(std::move(pass));
left_support->SubmitCompositorFrame(left_child_local_id,
@@ -306,7 +306,7 @@ TEST_F(SurfacesPixelTest, DrawAggregatedFrameWithSurfaceTransforms) {
SK_ColorGREEN,
force_anti_aliasing_off);
- CompositorFrame child_frame;
+ CompositorFrame child_frame = test::MakeCompositorFrame();
child_frame.render_pass_list.push_back(std::move(pass));
right_support->SubmitCompositorFrame(right_child_local_id,

Powered by Google App Engine
This is Rietveld 408576698