Fix race with google variation ID registration

Fix race with google variation ID registration

If ExternalDataUseObserverBridge::ShouldRegisterAsDataUseObserver() is
called before ExternalDataUseObserverBridge::SetRegisterGoogleVariationID
is called, GWS id will not be registered. This CL fixes that.

This CL also renames SetRegisterGoogleVariationID appropriately to
SetProfileSigninStatus in some files

BUG=714281
Review-Url: https://codereview.chromium.org/2834463005
Cr-Commit-Position: refs/heads/master@{#466464}
Committed: https://chromium.googlesource.com/chromium/src/+/96efb190e51a943b44485a8b3c53338498814c43

[Raj, 2017-04-20 23:00:49]

Description was changed from

==========
Fix race with GWS ID registration

If ExternalDataUseObserverBridge::ShouldRegisterAsDataUseObserver() is
called before ExternalDataUseObserverBridge::SetRegisterGoogleVariationID
is called, GWS id will not be registered. This CL fixes that.

This CL also renames SetRegisterGoogleVariationID appropriately to
SetProfileSigninStatus in some files

BUG=
==========

to

==========
Fix race with google variation ID registration

If ExternalDataUseObserverBridge::ShouldRegisterAsDataUseObserver() is
called before ExternalDataUseObserverBridge::SetRegisterGoogleVariationID
is called, GWS id will not be registered. This CL fixes that.

This CL also renames SetRegisterGoogleVariationID appropriately to
SetProfileSigninStatus in some files

BUG=
==========

[Raj, 2017-04-20 23:01:02]

rajendrant@chromium.org changed reviewers:
+ sclittle@chromium.org

[Raj, 2017-04-20 23:01:02]

ptal

[sclittle, 2017-04-21 01:14:15]

Could you link to a relevant crbug in the CL description?

LGTM so long as you've tested this and verified that it works.

[Raj, 2017-04-21 16:13:58]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 16:14:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 16:51:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 16:51:11]

Dry run: This issue passed the CQ dry run.

[Raj, 2017-04-21 21:31:04]

The CQ bit was checked by rajendrant@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 21:31:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Raj, 2017-04-21 21:36:32]

Description was changed from

==========
Fix race with google variation ID registration

If ExternalDataUseObserverBridge::ShouldRegisterAsDataUseObserver() is
called before ExternalDataUseObserverBridge::SetRegisterGoogleVariationID
is called, GWS id will not be registered. This CL fixes that.

This CL also renames SetRegisterGoogleVariationID appropriately to
SetProfileSigninStatus in some files

BUG=
==========

to

==========
Fix race with google variation ID registration

If ExternalDataUseObserverBridge::ShouldRegisterAsDataUseObserver() is
called before ExternalDataUseObserverBridge::SetRegisterGoogleVariationID
is called, GWS id will not be registered. This CL fixes that.

This CL also renames SetRegisterGoogleVariationID appropriately to
SetProfileSigninStatus in some files

BUG=714281
==========

[commit-bot: I haz the power, 2017-04-21 22:09:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 22:09:31]

Dry run: This issue passed the CQ dry run.

[Raj, 2017-04-21 22:12:34]

The CQ bit was checked by rajendrant@chromium.org

[Raj, 2017-04-21 22:12:34]

The patchset sent to the CQ was uploaded after l-g-t-m from
sclittle@chromium.org
Link to the patchset: https://codereview.chromium.org/2834463005/#ps20001
(title: "rebased")

[commit-bot: I haz the power, 2017-04-21 22:13:13]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 22:17:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1492812754211240,
"parent_rev": "0db41d57152ce8627b01a5a221424d5787ab236a", "commit_rev":
"96efb190e51a943b44485a8b3c53338498814c43"}

[commit-bot: I haz the power, 2017-04-21 22:18:08]

Description was changed from

==========
Fix race with google variation ID registration

If ExternalDataUseObserverBridge::ShouldRegisterAsDataUseObserver() is
called before ExternalDataUseObserverBridge::SetRegisterGoogleVariationID
is called, GWS id will not be registered. This CL fixes that.

This CL also renames SetRegisterGoogleVariationID appropriately to
SetProfileSigninStatus in some files

BUG=714281
==========

to

==========
Fix race with google variation ID registration

If ExternalDataUseObserverBridge::ShouldRegisterAsDataUseObserver() is
called before ExternalDataUseObserverBridge::SetRegisterGoogleVariationID
is called, GWS id will not be registered. This CL fixes that.

This CL also renames SetRegisterGoogleVariationID appropriately to
SetProfileSigninStatus in some files

BUG=714281

Review-Url: https://codereview.chromium.org/2834463005
Cr-Commit-Position: refs/heads/master@{#466464}
Committed:
https://chromium.googlesource.com/chromium/src/+/96efb190e51a943b44485a8b3c53...
==========

[commit-bot: I haz the power, 2017-04-21 22:18:09]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/96efb190e51a943b44485a8b3c53...