Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Unified Diff: chrome/browser/android/data_usage/data_use_ui_tab_model_factory.cc

Issue 2834463005: Fix race with google variation ID registration (Closed)
Patch Set: rebased Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/android/data_usage/external_data_use_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/data_usage/data_use_ui_tab_model_factory.cc
diff --git a/chrome/browser/android/data_usage/data_use_ui_tab_model_factory.cc b/chrome/browser/android/data_usage/data_use_ui_tab_model_factory.cc
index b3b252db497a0d379f7eb6d3a04e26db976eed8b..cc06266db2008c36fcdb359515b263842dd37e43 100644
--- a/chrome/browser/android/data_usage/data_use_ui_tab_model_factory.cc
+++ b/chrome/browser/android/data_usage/data_use_ui_tab_model_factory.cc
@@ -37,16 +37,14 @@ DataUseTabModel* GetDataUseTabModelOnIOThread(IOThread* io_thread) {
return io_thread->globals()->external_data_use_observer->GetDataUseTabModel();
}
-void SetRegisterGoogleVariationIDOnIOThread(IOThread* io_thread,
- bool register_google_variation_id) {
+void SetProfileSigninStatusOnIOThread(IOThread* io_thread, bool signin_status) {
DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
// Avoid null pointer referencing during browser shutdown.
- if (io_thread && !io_thread->globals() &&
+ if (io_thread && io_thread->globals() &&
io_thread->globals()->external_data_use_observer) {
- io_thread->globals()
- ->external_data_use_observer->SetRegisterGoogleVariationID(
- register_google_variation_id);
+ io_thread->globals()->external_data_use_observer->SetProfileSigninStatus(
+ signin_status);
}
}
@@ -95,7 +93,7 @@ KeyedService* DataUseUITabModelFactory::BuildServiceInstanceFor(
content::BrowserThread::PostTask(
content::BrowserThread::IO, FROM_HERE,
- base::Bind(&SetRegisterGoogleVariationIDOnIOThread,
+ base::Bind(&SetProfileSigninStatusOnIOThread,
g_browser_process->io_thread(),
signin_manager && signin_manager->IsAuthenticated()));
« no previous file with comments | « no previous file | chrome/browser/android/data_usage/external_data_use_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698