chrome/browser/android/data_usage/external_data_use_observer_bridge.h - Issue 2834463005: Fix race with google variation ID registration

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/data_usage/external_data_use_observer_bridge.h

Issue 2834463005: Fix race with google variation ID registration (Closed)

Patch Set: rebased Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/android/data_usage/external_data_use_observer.cc ('k') | chrome/browser/android/data_usage/external_data_use_observer_bridge.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/android/data_usage/external_data_use_observer_bridge.h

diff --git a/chrome/browser/android/data_usage/external_data_use_observer_bridge.h b/chrome/browser/android/data_usage/external_data_use_observer_bridge.h

index b8ae22301ff408baac38d15b3b9be6a06ae97ba7..3d4a0c7a248321c06032a5975665f1e324274121 100644

--- a/chrome/browser/android/data_usage/external_data_use_observer_bridge.h

+++ b/chrome/browser/android/data_usage/external_data_use_observer_bridge.h

@@ -98,7 +98,7 @@ class ExternalDataUseObserverBridge {

// should register as a data use observer.

virtual void ShouldRegisterAsDataUseObserver(bool should_register) const;

- void SetRegisterGoogleVariationID(bool register_google_variation_id);

+ void RegisterGoogleVariationID(bool should_register);

private:

// Java listener that provides regular expressions to |this|. Data use

@@ -119,9 +119,6 @@ class ExternalDataUseObserverBridge {

// True if matching rules are fetched for the first time.

bool is_first_matching_rule_fetch_;

- // True if Google variation ID should be registered.

- bool register_google_variation_id_;

// |io_task_runner_| accesses ExternalDataUseObserver members on IO thread.

scoped_refptr<base::SingleThreadTaskRunner> io_task_runner_;