Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 2834073003: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome (Closed)

Created:
3 years, 8 months ago by Byoungkwon Ko
Modified:
3 years, 7 months ago
CC:
chromium-reviews, gcasto+watchlist_chromium.org, sync-reviews_chromium.org, tfarina, vabr+watchlistpasswordmanager_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome BUG=644626 Review-Url: https://codereview.chromium.org/2834073003 Cr-Commit-Position: refs/heads/master@{#468965} Committed: https://chromium.googlesource.com/chromium/src/+/e6e2d301f7a892c62098da14c7f47eec0aad40f8

Patch Set 1 #

Patch Set 2 : Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome #

Patch Set 3 : Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -6 lines) Patch
M components/bookmarks/browser/bookmark_utils_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/feature_engagement_tracker/internal/in_memory_store_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M components/policy/core/common/cloud/external_policy_data_fetcher_unittest.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M components/sync/engine_impl/cycle/data_type_tracker.cc View 1 2 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 29 (20 generated)
Byoungkwon Ko
PTAL
3 years, 8 months ago (2017-04-25 00:01:57 UTC) #14
vabr (Chromium)
components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc LGTM, thanks for the clean-up! Vaclav
3 years, 8 months ago (2017-04-25 09:57:50 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834073003/40001
3 years, 7 months ago (2017-04-28 22:07:22 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/423753)
3 years, 7 months ago (2017-04-28 22:17:45 UTC) #20
Byoungkwon Ko
PTAL
3 years, 7 months ago (2017-04-29 00:33:59 UTC) #22
blundell
lgtm
3 years, 7 months ago (2017-05-02 07:13:29 UTC) #23
jochen (gone - plz use gerrit)
lgtm
3 years, 7 months ago (2017-05-02 09:06:45 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834073003/40001
3 years, 7 months ago (2017-05-03 13:53:30 UTC) #26
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 14:43:41 UTC) #29
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e6e2d301f7a892c62098da14c7f4...

Powered by Google App Engine
This is Rietveld 408576698