components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc - Issue 2834073003: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

Issue 2834073003: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome (Closed)

Patch Set: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/feature_engagement_tracker/internal/in_memory_store_unittest.cc ('k') | components/policy/core/common/cloud/external_policy_data_fetcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

diff --git a/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc b/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

index 6e432dfb60f6036c932532104bbd06d05d8f6acd..3ba8c194cfa95d4454d11eaa12ce49ef5562b7f7 100644

--- a/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

+++ b/components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc

@@ -2,6 +2,8 @@

// Use of this source code is governed by a BSD-style license that can be

// found in the LICENSE file.

+#include <utility>

#include "base/json/json_writer.h"

#include "base/macros.h"

#include "base/metrics/field_trial.h"

@@ -192,7 +194,7 @@ class PasswordManagerSettingMigratorServiceTest : public testing::Test {

pref_service_syncable = factory.CreateSyncable(pref_registry.get());

migration_service_.reset(

new PasswordManagerSettingMigratorService(pref_service_syncable.get()));

- pref_service_.reset(pref_service_syncable.release());

+ pref_service_ = std::move(pref_service_syncable);

}

void ExpectValuesForBothPrefValues(bool new_pref_value, bool old_pref_value) {