components/feature_engagement_tracker/internal/in_memory_store_unittest.cc - Issue 2834073003: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/feature_engagement_tracker/internal/in_memory_store_unittest.cc

Issue 2834073003: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome (Closed)

Patch Set: Replace unique_ptr.reset(other_unique_ptr.release()) with std::move() in chrome Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/bookmarks/browser/bookmark_utils_unittest.cc ('k') | components/password_manager/sync/browser/password_manager_setting_migrator_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/feature_engagement_tracker/internal/in_memory_store_unittest.cc

diff --git a/components/feature_engagement_tracker/internal/in_memory_store_unittest.cc b/components/feature_engagement_tracker/internal/in_memory_store_unittest.cc

index be3f0ad2910f7fa20582c0f16f8714c7718e7d7b..593f866113d1dfb0240dfd1df1e068b2008bfeca 100644

--- a/components/feature_engagement_tracker/internal/in_memory_store_unittest.cc

+++ b/components/feature_engagement_tracker/internal/in_memory_store_unittest.cc

@@ -5,6 +5,7 @@

#include "components/feature_engagement_tracker/internal/in_memory_store.h"

#include <memory>

+#include <utility>

#include <vector>

#include "base/bind.h"

@@ -26,7 +27,7 @@ class InMemoryStoreTest : public ::testing::Test {

void LoadCallback(bool success, std::unique_ptr<std::vector<Event>> events) {

load_callback_has_been_invoked_ = true;

last_result_ = success;

- loaded_events_.reset(events.release());

+ loaded_events_ = std::move(events);

}

protected: