DevTools: Fix timeline overview flickering

DevTools: Fix timeline overview flickering

BUG=700273
Review-Url: https://codereview.chromium.org/2834053004
Cr-Commit-Position: refs/heads/master@{#467202}
Committed: https://chromium.googlesource.com/chromium/src/+/3a0fdce4d4151a52fdfc3c67870887f25eb68ee9

[alph, 2017-04-21 22:37:03]

alph@chromium.org changed reviewers:
+ dgozman@chromium.org

[dgozman, 2017-04-21 23:04:05]

https://codereview.chromium.org/2834053004/diff/1/third_party/WebKit/Source/d...
File
third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js
(right):

https://codereview.chromium.org/2834053004/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js:485:
this._glassPane.contentElement.style.setProperty('pointer-events', 'none');
Why this? You should set pointer-events on your content instead.

[alph, 2017-04-21 23:22:35]

On 2017/04/21 23:04:05, dgozman wrote:
>
https://codereview.chromium.org/2834053004/diff/1/third_party/WebKit/Source/d...
> File
> third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js
> (right):
> 
>
https://codereview.chromium.org/2834053004/diff/1/third_party/WebKit/Source/d...
>
third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js:485:
> this._glassPane.contentElement.style.setProperty('pointer-events', 'none');
> Why this? You should set pointer-events on your content instead.

I do, but there's also a widget between my element and the glass pane.

[alph, 2017-04-25 21:54:15]

ptal

[dgozman, 2017-04-25 23:54:15]

lgtm

https://codereview.chromium.org/2834053004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js (right):

https://codereview.chromium.org/2834053004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js:60:
this.contentElement.style.setProperty(
I believe this can be class as well, since contentElement is inside of shadow
root.

[alph, 2017-04-26 00:13:49]

https://codereview.chromium.org/2834053004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js (right):

https://codereview.chromium.org/2834053004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/ui/GlassPane.js:60:
this.contentElement.style.setProperty(
On 2017/04/25 23:54:14, dgozman wrote:
> I believe this can be class as well, since contentElement is inside of shadow
> root.

Done.

[alph, 2017-04-26 00:13:52]

The CQ bit was checked by alph@chromium.org

[alph, 2017-04-26 00:13:52]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2834053004/#ps80001
(title: "addressing comment")

[commit-bot: I haz the power, 2017-04-26 00:14:39]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-26 02:04:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493165632345170,
"parent_rev": "de2639a09ee8be98b746c6785d83bb57ee6fa9c2", "commit_rev":
"3a0fdce4d4151a52fdfc3c67870887f25eb68ee9"}

[commit-bot: I haz the power, 2017-04-26 02:04:24]

Description was changed from

==========
DevTools: Fix timeline overview flickering

BUG=700273
==========

to

==========
DevTools: Fix timeline overview flickering

BUG=700273

Review-Url: https://codereview.chromium.org/2834053004
Cr-Commit-Position: refs/heads/master@{#467202}
Committed:
https://chromium.googlesource.com/chromium/src/+/3a0fdce4d4151a52fdfc3c678708...
==========

[commit-bot: I haz the power, 2017-04-26 02:04:31]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/3a0fdce4d4151a52fdfc3c678708...