third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js - Issue 2834053004: DevTools: Fix timeline overview flickering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

Issue 2834053004: DevTools: Fix timeline overview flickering (Closed)

Patch Set: addressing comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/inline_editor/SwatchPopoverHelper.js ('k') | third_party/WebKit/Source/devtools/front_end/perf_ui/timelineOverviewInfo.css » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

diff --git a/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js b/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

index 554115671313f366f7fc702a342f1887666ed4c3..f517e655f16a5a3090d8bb0e7aacaeebde2ac8d6 100644

--- a/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

+++ b/third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

@@ -479,8 +479,8 @@ PerfUI.TimelineOverviewPane.OverviewInfo = class {

constructor(anchor) {

this._anchorElement = anchor;

this._glassPane = new UI.GlassPane();

- this._glassPane.setBlockPointerEvents(false);

- this._glassPane.setMarginBehavior(UI.GlassPane.MarginBehavior.NoMargin);

+ this._glassPane.setPointerEventsBehavior(UI.GlassPane.PointerEventsBehavior.PierceContents);

+ this._glassPane.setMarginBehavior(UI.GlassPane.MarginBehavior.Arrow);

this._glassPane.setSizeBehavior(UI.GlassPane.SizeBehavior.MeasureContent);

this._element =

UI.createShadowRootWithCoreStyles(this._glassPane.contentElement, 'perf_ui/timelineOverviewInfo.css')