third_party/WebKit/Source/devtools/front_end/ui/Dialog.js - Issue 2834053004: DevTools: Fix timeline overview flickering

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

Issue 2834053004: DevTools: Fix timeline overview flickering (Closed)

Patch Set: addressing comment Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

diff --git a/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js b/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

index b905558849c8ab93c35bc1a815e82890b37ebd7c..aa64dee3987564e607ec427d760f199b59b22f61 100644

--- a/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

+++ b/third_party/WebKit/Source/devtools/front_end/ui/Dialog.js

@@ -35,7 +35,7 @@ UI.Dialog = class extends UI.GlassPane {

this.contentElement.tabIndex = 0;

this.contentElement.addEventListener('focus', () => this.widget().focus(), false);

this.contentElement.addEventListener('keydown', this._onKeyDown.bind(this), false);

- this.setBlockPointerEvents(true);

+ this.setPointerEventsBehavior(UI.GlassPane.PointerEventsBehavior.BlockedByGlassPane);

this.setSetOutsideClickCallback(event => {

this.hide();

event.consume(true);