Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(130)

Issue 2833683002: Revert of Reland Enable crashpad for Mac. (Closed)

Created:
3 years, 8 months ago by keishi
Modified:
3 years, 8 months ago
Reviewers:
dvallet, Sami
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland Enable crashpad for Mac. (patchset #1 id:1 of https://codereview.chromium.org/2820453003/ ) Reason for revert: CrashReporterTest.GenerateMinidump failing on Builder Mac10.10 Tests Original issue's description: > Reland Enable crashpad for Mac. > -- Add :mac_helpers dependendency to headless_lib > > > > Original reason for revert: Reason for revert: > mac_chromium10.10_rel_ng buildbot failing in browsertests > https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_Tests%2F16541%2F%2B%2Frecipes%2Fsteps%2Fheadless_browsertests_on_Mac-10.10%2F0%2Flogs%2FCrashReporterTest.GenerateMinidump%2F0 > > > This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders. > > For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle. > > BUG=687407 > > Review-Url: https://codereview.chromium.org/2816593006 > Cr-Commit-Position: refs/heads/master@{#464289} > Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3edfc83c522f32a > > patch from issue 2816593006 at patchset 60001 (http://crrev.com/2816593006#ps60001) > > Review-Url: https://codereview.chromium.org/2820453003 > Cr-Commit-Position: refs/heads/master@{#465869} > Committed: https://chromium.googlesource.com/chromium/src/+/df51c3e48120bc5f68e0fc2cdc92d91592249e98 TBR=skyostil@chromium.org,dvallet@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=687407

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -36 lines) Patch
M headless/BUILD.gn View 2 chunks +1 line, -19 lines 0 comments Download
M headless/lib/headless_browser_browsertest.cc View 2 chunks +3 lines, -8 lines 0 comments Download
M headless/lib/headless_content_main_delegate.cc View 3 chunks +6 lines, -9 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
keishi
Created Revert of Reland Enable crashpad for Mac.
3 years, 8 months ago (2017-04-20 04:05:48 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833683002/1
3 years, 8 months ago (2017-04-20 04:06:12 UTC) #3
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 04:06:31 UTC) #5
Failed to apply patch for headless/BUILD.gn:
While running git apply --index -3 -p1;
  error: patch failed: headless/BUILD.gn:323
  error: repository lacks the necessary blob to fall back on 3-way merge.
  error: headless/BUILD.gn: patch does not apply

Patch:       headless/BUILD.gn
Index: headless/BUILD.gn
diff --git a/headless/BUILD.gn b/headless/BUILD.gn
index
a4a762ef2914c01d990e0ee8b26f61d30112e806..6345e098a44e826849f1c47b48357d3ed5478f6c
100644
--- a/headless/BUILD.gn
+++ b/headless/BUILD.gn
@@ -323,9 +323,7 @@
     "//url",
   ]
 
-  if (is_mac) {
-    deps += [ ":mac_helpers" ]
-  } else {
+  if (!is_mac) {
     deps += [ "//ui/aura" ]
   }
 
@@ -413,22 +411,6 @@
   deps = [
     ":headless_browsertest_resources_grit",
   ]
-}
-
-if (is_mac) {
-  copy("mac_helpers") {
-    sources = [
-      "$root_out_dir/crashpad_handler",
-    ]
-
-    deps = [
-      "//third_party/crashpad/crashpad/handler:crashpad_handler",
-    ]
-
-    outputs = [
-      "$root_out_dir/Helpers/{{source_file_part}}",
-    ]
-  }
 }
 
 test("headless_browsertests") {

Powered by Google App Engine
This is Rietveld 408576698