Enable crashpad for Mac

Enable crashpad for Mac.

This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders.

For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle.

BUG=687407
Review-Url: https://codereview.chromium.org/2816593006
Cr-Commit-Position: refs/heads/master@{#464289}
Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3edfc83c522f32a

[dvallet, 2017-04-12 05:05:06]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-12 05:05:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dvallet, 2017-04-12 05:07:23]

Description was changed from

==========
Enable crashpad for Mac

BUG=687407
==========

to

==========
Enable crashpad for Mac.

This follows the same logic as using breakpad in linux with flags
--enable_crash-reporter and --crash-dumps-dir folders. 

For headless_shell target, we need to include the Helper crashpad_handler in the
build. For --headless, this is already available in the framework bundle. 

BUG=687407
==========

[dvallet, 2017-04-12 05:22:34]

dvallet@chromium.org changed reviewers:
+ jzfeng@chromium.org, skyostil@chromium.org

[dvallet, 2017-04-12 05:22:35]

PTAL

[jzfeng, 2017-04-12 06:22:04]

https://codereview.chromium.org/2816593006/diff/1/headless/BUILD.gn
File headless/BUILD.gn (right):

https://codereview.chromium.org/2816593006/diff/1/headless/BUILD.gn#newcode485
headless/BUILD.gn:485: ]
nit: put sources and outputs above deps?

https://codereview.chromium.org/2816593006/diff/1/headless/lib/headless_conte...
File headless/lib/headless_content_main_delegate.cc (right):

https://codereview.chromium.org/2816593006/diff/1/headless/lib/headless_conte...
headless/lib/headless_content_main_delegate.cc:160: const base::CommandLine&
command_line,
command_line is not used?

https://codereview.chromium.org/2816593006/diff/1/headless/lib/headless_conte...
headless/lib/headless_content_main_delegate.cc:183:
InitMacCrashReporter(command_line, process_type);
there is only two line of code, just put them here?

[commit-bot: I haz the power, 2017-04-12 06:28:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 06:28:15]

Dry run: This issue passed the CQ dry run.

[dvallet, 2017-04-12 07:04:03]

The CQ bit was checked by dvallet@chromium.org to run a CQ dry run

[dvallet, 2017-04-12 07:04:09]

https://codereview.chromium.org/2816593006/diff/1/headless/BUILD.gn
File headless/BUILD.gn (right):

https://codereview.chromium.org/2816593006/diff/1/headless/BUILD.gn#newcode485
headless/BUILD.gn:485: ]
On 2017/04/12 06:22:04, jzfeng wrote:
> nit: put sources and outputs above deps?

Done.

https://codereview.chromium.org/2816593006/diff/1/headless/lib/headless_conte...
File headless/lib/headless_content_main_delegate.cc (right):

https://codereview.chromium.org/2816593006/diff/1/headless/lib/headless_conte...
headless/lib/headless_content_main_delegate.cc:160: const base::CommandLine&
command_line,
On 2017/04/12 06:22:04, jzfeng wrote:
> command_line is not used?

Done.

https://codereview.chromium.org/2816593006/diff/1/headless/lib/headless_conte...
headless/lib/headless_content_main_delegate.cc:183:
InitMacCrashReporter(command_line, process_type);
On 2017/04/12 06:22:04, jzfeng wrote:
> there is only two line of code, just put them here?

Done. I'm expecting to add more stuff later for crash reports, but yeah maybe I
can create the function if needed.

[commit-bot: I haz the power, 2017-04-12 07:04:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jzfeng, 2017-04-12 07:11:06]

lgtm

[commit-bot: I haz the power, 2017-04-12 08:26:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-12 08:26:19]

Dry run: This issue passed the CQ dry run.

[Sami, 2017-04-12 13:16:42]

Looks great! Could you also add a test for this? (See CrashReporterTest for a
template)

[Sami, 2017-04-12 16:10:38]

Oh and lgtm with a test.

[dvallet, 2017-04-13 00:53:05]

Thanks! test added

[dvallet, 2017-04-13 00:53:11]

The CQ bit was checked by dvallet@chromium.org

[dvallet, 2017-04-13 00:53:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
skyostil@chromium.org, jzfeng@chromium.org
Link to the patchset: https://codereview.chromium.org/2816593006/#ps60001
(title: "Add mac_helpers for browser tests")

[commit-bot: I haz the power, 2017-04-13 00:54:37]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-13 03:57:31]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1492044791443860,
"parent_rev": "6a48a45ac9c3138e306f19df0b3fc1974ffe33ec", "commit_rev":
"ecb2ad24952b077e71e56ba9d3edfc83c522f32a"}

[commit-bot: I haz the power, 2017-04-13 04:39:45]

Description was changed from

==========
Enable crashpad for Mac.

This follows the same logic as using breakpad in linux with flags
--enable_crash-reporter and --crash-dumps-dir folders. 

For headless_shell target, we need to include the Helper crashpad_handler in the
build. For --headless, this is already available in the framework bundle. 

BUG=687407
==========

to

==========
Enable crashpad for Mac.

This follows the same logic as using breakpad in linux with flags
--enable_crash-reporter and --crash-dumps-dir folders.

For headless_shell target, we need to include the Helper crashpad_handler in the
build. For --headless, this is already available in the framework bundle.

BUG=687407

Review-Url: https://codereview.chromium.org/2816593006
Cr-Commit-Position: refs/heads/master@{#464289}
Committed:
https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3ed...
==========

[commit-bot: I haz the power, 2017-04-13 04:39:46]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3ed...

[findit-for-me, 2017-04-13 04:59:49]

Findit(https://goo.gl/kROfz5) identified this CL at revision 464289 as the
culprit for
failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3Itb...

[dvallet, 2017-04-13 05:05:14]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2819503002/ by dvallet@chromium.org.

The reason for reverting is: mac_chromium10.10_rel_ng buildbot failing in
browsertests.