Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2820453003:
Reland Enable crashpad for Mac. (Closed)
DescriptionReland Enable crashpad for Mac.
-- Add :mac_helpers dependendency to headless_lib
Original reason for revert: Reason for revert:
mac_chromium10.10_rel_ng buildbot failing in browsertests
https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_Tests%2F16541%2F%2B%2Frecipes%2Fsteps%2Fheadless_browsertests_on_Mac-10.10%2F0%2Flogs%2FCrashReporterTest.GenerateMinidump%2F0
This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders.
For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle.
BUG=687407
Review-Url: https://codereview.chromium.org/2816593006
Cr-Commit-Position: refs/heads/master@{#464289}
Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3edfc83c522f32a
patch from issue 2816593006 at patchset 60001 (http://crrev.com/2816593006#ps60001)
Review-Url: https://codereview.chromium.org/2820453003
Cr-Original-Commit-Position: refs/heads/master@{#465869}
Committed: https://chromium.googlesource.com/chromium/src/+/df51c3e48120bc5f68e0fc2cdc92d91592249e98
Review-Url: https://codereview.chromium.org/2820453003
Cr-Commit-Position: refs/heads/master@{#466275}
Committed: https://chromium.googlesource.com/chromium/src/+/375a20a84a2d9001b4f87fffdb0bb1aa4b4e0862
Patch Set 1 #Patch Set 2 : adding crashpad_handler to test isolate #Patch Set 3 : Updated upstream #
Messages
Total messages: 26 (16 generated)
The CQ bit was checked by dvallet@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
dvallet@chromium.org changed reviewers: + skyostil@chromium.org
PTAL I'll see if I can reland this. I've checked the test build and Helpers/crashpad_handler is included, so I'm not sure why the error occurred. python -u scripts/tools/runit.py --show-path -- python scripts/slave/extract_build.py --gsutil-py-path /Users/dvallet/depot_tools/gsutil.py --target Release --src-dir /tmp/Mac10_10_Tests/src --slave-utils-gsutil-py-path /Users/dvallet/depot_tools/gsutil.py --build-url 'gs://chromium-mac-archive/chromium.mac/Mac Builder/full-build-mac.zip' --build_revision ebc15025d19fb3a0be141495f36f36b5cd73673e --master-name chromium.mac --build-number 16543 --parent-build-number 65292
lgtm to reland
The CQ bit was checked by dvallet@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1492651107162930, "parent_rev":
"3d95cd94f4cd59f9ab6603f0cde95d32ecdbed77", "commit_rev":
"df51c3e48120bc5f68e0fc2cdc92d91592249e98"}
Message was sent while issue was closed.
Description was changed from ========== Reland Enable crashpad for Mac. -- Add :mac_helpers dependendency to headless_lib Original reason for revert: Reason for revert: mac_chromium10.10_rel_ng buildbot failing in browsertests https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_... This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders. For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle. BUG=687407 Review-Url: https://codereview.chromium.org/2816593006 Cr-Commit-Position: refs/heads/master@{#464289} Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3ed... patch from issue 2816593006 at patchset 60001 (http://crrev.com/2816593006#ps60001) ========== to ========== Reland Enable crashpad for Mac. -- Add :mac_helpers dependendency to headless_lib Original reason for revert: Reason for revert: mac_chromium10.10_rel_ng buildbot failing in browsertests https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_... This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders. For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle. BUG=687407 Review-Url: https://codereview.chromium.org/2816593006 Cr-Commit-Position: refs/heads/master@{#464289} Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3ed... patch from issue 2816593006 at patchset 60001 (http://crrev.com/2816593006#ps60001) Review-Url: https://codereview.chromium.org/2820453003 Cr-Commit-Position: refs/heads/master@{#465869} Committed: https://chromium.googlesource.com/chromium/src/+/df51c3e48120bc5f68e0fc2cdc92... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/df51c3e48120bc5f68e0fc2cdc92...
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2826193003/ by aboxhall@chromium.org. The reason for reverting is: Sorry, looks like this is still causing some test failures: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_... https://uberchromegw.corp.google.com/i/chromium.mac/builders/Mac10.10%20Tests....
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2833683002/ by keishi@chromium.org. The reason for reverting is: CrashReporterTest.GenerateMinidump failing on Builder Mac10.10 Tests.
Message was sent while issue was closed.
Description was changed from ========== Reland Enable crashpad for Mac. -- Add :mac_helpers dependendency to headless_lib Original reason for revert: Reason for revert: mac_chromium10.10_rel_ng buildbot failing in browsertests https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_... This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders. For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle. BUG=687407 Review-Url: https://codereview.chromium.org/2816593006 Cr-Commit-Position: refs/heads/master@{#464289} Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3ed... patch from issue 2816593006 at patchset 60001 (http://crrev.com/2816593006#ps60001) Review-Url: https://codereview.chromium.org/2820453003 Cr-Commit-Position: refs/heads/master@{#465869} Committed: https://chromium.googlesource.com/chromium/src/+/df51c3e48120bc5f68e0fc2cdc92... ========== to ========== Reland Enable crashpad for Mac. -- Add :mac_helpers dependendency to headless_lib Original reason for revert: Reason for revert: mac_chromium10.10_rel_ng buildbot failing in browsertests https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_... This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders. For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle. BUG=687407 Review-Url: https://codereview.chromium.org/2816593006 Cr-Commit-Position: refs/heads/master@{#464289} Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3ed... patch from issue 2816593006 at patchset 60001 (http://crrev.com/2816593006#ps60001) Review-Url: https://codereview.chromium.org/2820453003 Cr-Commit-Position: refs/heads/master@{#465869} Committed: https://chromium.googlesource.com/chromium/src/+/df51c3e48120bc5f68e0fc2cdc92... ==========
The CQ bit was checked by dvallet@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/2820453003/#ps20001 (title: "adding crashpad_handler to test isolate")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...) chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...) linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by dvallet@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from skyostil@chromium.org Link to the patchset: https://codereview.chromium.org/2820453003/#ps40001 (title: "Updated upstream")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1492753044375660,
"parent_rev": "1d9c0272a5d06697b9e633f7140fcbfd7ff2b1fe", "commit_rev":
"375a20a84a2d9001b4f87fffdb0bb1aa4b4e0862"}
Message was sent while issue was closed.
Description was changed from ========== Reland Enable crashpad for Mac. -- Add :mac_helpers dependendency to headless_lib Original reason for revert: Reason for revert: mac_chromium10.10_rel_ng buildbot failing in browsertests https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_... This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders. For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle. BUG=687407 Review-Url: https://codereview.chromium.org/2816593006 Cr-Commit-Position: refs/heads/master@{#464289} Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3ed... patch from issue 2816593006 at patchset 60001 (http://crrev.com/2816593006#ps60001) Review-Url: https://codereview.chromium.org/2820453003 Cr-Commit-Position: refs/heads/master@{#465869} Committed: https://chromium.googlesource.com/chromium/src/+/df51c3e48120bc5f68e0fc2cdc92... ========== to ========== Reland Enable crashpad for Mac. -- Add :mac_helpers dependendency to headless_lib Original reason for revert: Reason for revert: mac_chromium10.10_rel_ng buildbot failing in browsertests https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.mac%2FMac10.10_... This follows the same logic as using breakpad in linux with flags --enable_crash-reporter and --crash-dumps-dir folders. For headless_shell target, we need to include the Helper crashpad_handler in the build. For --headless, this is already available in the framework bundle. BUG=687407 Review-Url: https://codereview.chromium.org/2816593006 Cr-Commit-Position: refs/heads/master@{#464289} Committed: https://chromium.googlesource.com/chromium/src/+/ecb2ad24952b077e71e56ba9d3ed... patch from issue 2816593006 at patchset 60001 (http://crrev.com/2816593006#ps60001) Review-Url: https://codereview.chromium.org/2820453003 Cr-Original-Commit-Position: refs/heads/master@{#465869} Committed: https://chromium.googlesource.com/chromium/src/+/df51c3e48120bc5f68e0fc2cdc92... Review-Url: https://codereview.chromium.org/2820453003 Cr-Commit-Position: refs/heads/master@{#466275} Committed: https://chromium.googlesource.com/chromium/src/+/375a20a84a2d9001b4f87fffdb0b... ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/375a20a84a2d9001b4f87fffdb0b... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
