Extract IsKnownRoot() functionality for testing if a certificate is a

Extract IsKnownRoot() functionality for testing if a certificate is a
standard root.

This way it can be re-used by the builtin cert verifier too.

BUG=649017
Review-Url: https://codereview.chromium.org/2833623002
Cr-Commit-Position: refs/heads/master@{#466100}
Committed: https://chromium.googlesource.com/chromium/src/+/f2971fd2585293ba4b3731965b80a3e338806dab

[eroman, 2017-04-19 23:00:00]

Description was changed from

==========
Extract IsKnownRoot() functionality for testing of a certificate is a
standard root.

This way it can be used by the builtin cert verifier too.

BUG=2829783002
==========

to

==========
Extract IsKnownRoot() functionality for testing if a certificate is a
standard root.

This way it can be used by the builtin cert verifier too.

BUG=2829783002
==========

[eroman, 2017-04-19 23:00:14]

Description was changed from

==========
Extract IsKnownRoot() functionality for testing if a certificate is a
standard root.

This way it can be used by the builtin cert verifier too.

BUG=2829783002
==========

to

==========
Extract IsKnownRoot() functionality for testing if a certificate is a
standard root.

This way it can be re-used by the builtin cert verifier too.

BUG=2829783002
==========

[eroman, 2017-04-19 23:03:49]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 23:04:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-04-19 23:20:59]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-19 23:21:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-04-19 23:22:53]

eroman@chromium.org changed reviewers:
+ mattm@chromium.org

[commit-bot: I haz the power, 2017-04-20 00:37:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 00:37:30]

Dry run: This issue passed the CQ dry run.

[mattm, 2017-04-20 02:14:12]

bad BUG= number in description

lgtm w/nits

https://codereview.chromium.org/2833623002/diff/60001/net/cert/internal/syste...
File net/cert/internal/system_trust_store.cc (right):

https://codereview.chromium.org/2833623002/diff/60001/net/cert/internal/syste...
net/cert/internal/system_trust_store.cc:99: return
net::IsKnownRoot(nss_cert.get());
unnecessary net::

https://codereview.chromium.org/2833623002/diff/60001/net/cert/internal/syste...
net/cert/internal/system_trust_store.cc:144: return net::IsKnownRoot(cert_ref);
unnecessary net::

https://codereview.chromium.org/2833623002/diff/60001/net/cert/known_roots_ma...
File net/cert/known_roots_mac.cc (right):

https://codereview.chromium.org/2833623002/diff/60001/net/cert/known_roots_ma...
net/cert/known_roots_mac.cc:12: #include "base/sha1.h"
unnecessary?

https://codereview.chromium.org/2833623002/diff/60001/net/cert/known_roots_ma...
net/cert/known_roots_mac.cc:14: #include "crypto/sha2.h"
unnecessary?

https://codereview.chromium.org/2833623002/diff/60001/net/cert/known_roots_nss.h
File net/cert/known_roots_nss.h (right):

https://codereview.chromium.org/2833623002/diff/60001/net/cert/known_roots_ns...
net/cert/known_roots_nss.h:8: #include <certt.h>

typedef struct CERTCertificateStr CERTCertificate;

[eroman, 2017-04-20 17:30:50]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[eroman, 2017-04-20 17:31:00]

https://codereview.chromium.org/2833623002/diff/60001/net/cert/internal/syste...
File net/cert/internal/system_trust_store.cc (right):

https://codereview.chromium.org/2833623002/diff/60001/net/cert/internal/syste...
net/cert/internal/system_trust_store.cc:99: return
net::IsKnownRoot(nss_cert.get());
On 2017/04/20 02:14:12, mattm wrote:
> unnecessary net::

Unfortunately the unqualified symbol name will resolve to
SystemTrustStoreNSS::IsKnownRoot(), despite the different argument type (and
fail to compile).

I added the net:: namespace specificity to cause it to resolve to the right
overload.

I am not sure of a better way to tackle this short of giving them unique names.

https://codereview.chromium.org/2833623002/diff/60001/net/cert/known_roots_ma...
File net/cert/known_roots_mac.cc (right):

https://codereview.chromium.org/2833623002/diff/60001/net/cert/known_roots_ma...
net/cert/known_roots_mac.cc:12: #include "base/sha1.h"
On 2017/04/20 02:14:12, mattm wrote:
> unnecessary?

Done.

https://codereview.chromium.org/2833623002/diff/60001/net/cert/known_roots_ma...
net/cert/known_roots_mac.cc:14: #include "crypto/sha2.h"
On 2017/04/20 02:14:12, mattm wrote:
> unnecessary?

Done.

https://codereview.chromium.org/2833623002/diff/60001/net/cert/known_roots_nss.h
File net/cert/known_roots_nss.h (right):

https://codereview.chromium.org/2833623002/diff/60001/net/cert/known_roots_ns...
net/cert/known_roots_nss.h:8: #include <certt.h>
On 2017/04/20 02:14:12, mattm wrote:
> 
> typedef struct CERTCertificateStr CERTCertificate;

Done.

[commit-bot: I haz the power, 2017-04-20 17:31:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-04-20 17:32:30]

Description was changed from

==========
Extract IsKnownRoot() functionality for testing if a certificate is a
standard root.

This way it can be re-used by the builtin cert verifier too.

BUG=2829783002
==========

to

==========
Extract IsKnownRoot() functionality for testing if a certificate is a
standard root.

This way it can be re-used by the builtin cert verifier too.

BUG=649017
==========

[eroman, 2017-04-20 17:36:03]

Patchset #8 (id:140001) has been deleted

[eroman, 2017-04-20 17:36:11]

Patchset #7 (id:120001) has been deleted

[eroman, 2017-04-20 17:36:19]

Patchset #6 (id:100001) has been deleted

[eroman, 2017-04-20 17:40:49]

The CQ bit was checked by eroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 17:41:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[eroman, 2017-04-20 18:20:26]

The CQ bit was unchecked by eroman@chromium.org

[eroman, 2017-04-20 18:20:30]

The CQ bit was checked by eroman@chromium.org

[eroman, 2017-04-20 18:20:31]

The patchset sent to the CQ was uploaded after l-g-t-m from mattm@chromium.org
Link to the patchset: https://codereview.chromium.org/2833623002/#ps160001
(title: "remove another unused header")

[commit-bot: I haz the power, 2017-04-20 18:21:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 20:10:49]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1492712430559390,
"parent_rev": "b9e4631681ee89c4dd99af8f4832df70e654e883", "commit_rev":
"f2971fd2585293ba4b3731965b80a3e338806dab"}

[commit-bot: I haz the power, 2017-04-20 20:10:57]

Description was changed from

==========
Extract IsKnownRoot() functionality for testing if a certificate is a
standard root.

This way it can be re-used by the builtin cert verifier too.

BUG=649017
==========

to

==========
Extract IsKnownRoot() functionality for testing if a certificate is a
standard root.

This way it can be re-used by the builtin cert verifier too.

BUG=649017

Review-Url: https://codereview.chromium.org/2833623002
Cr-Commit-Position: refs/heads/master@{#466100}
Committed:
https://chromium.googlesource.com/chromium/src/+/f2971fd2585293ba4b3731965b80...
==========

[commit-bot: I haz the power, 2017-04-20 20:10:58]

Committed patchset #6 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/f2971fd2585293ba4b3731965b80...