Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 2833303002: Merge "window.print() should close form validation bubble." to M59 (Closed)

Created:
3 years, 8 months ago by tkent
Modified:
3 years, 8 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3071
Project:
chromium
Visibility:
Public.

Description

Merge "window.print() should close form validation bubble." to M59 Usually, window.open() deactivates the origin window and validation bubble on the origin window is closed. However, if window.print() is executed, it suspends message loop of the window, and deactivation isn't noticed until print dialog is closed. So, we need to close validation popup explicitly for window.print(). BUG=713686 Review-Url: https://codereview.chromium.org/2834783002 Cr-Commit-Position: refs/heads/master@{#466273} (cherry picked from commit 9dbd356b0cc52911caef089b09de63572cd9e39f) Review-Url: https://codereview.chromium.org/2833303002 . Cr-Commit-Position: refs/branch-heads/3071@{#151} Cr-Branched-From: a106f0abbf69dad349d4aaf4bcc4f5d376dd2377-refs/heads/master@{#464641} Committed: https://chromium.googlesource.com/chromium/src/+/31455b249cf2737bf96ab751252b84e8c85b3804

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M third_party/WebKit/Source/web/ChromeClientImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ValidationMessageClientImpl.h View 3 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
tkent
3 years, 8 months ago (2017-04-24 00:59:34 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
31455b249cf2737bf96ab751252b84e8c85b3804.

Powered by Google App Engine
This is Rietveld 408576698