Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Side by Side Diff: third_party/WebKit/Source/web/ChromeClientImpl.cpp

Issue 2833303002: Merge "window.print() should close form validation bubble." to M59 (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2009 Google Inc. All rights reserved.
3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies). 3 * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies).
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions are 6 * modification, are permitted provided that the following conditions are
7 * met: 7 * met:
8 * 8 *
9 * * Redistributions of source code must retain the above copyright 9 * * Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 669 matching lines...) Expand 10 before | Expand all | Expand 10 after
680 did_request_non_empty_tool_tip_ = false; 680 did_request_non_empty_tool_tip_ = false;
681 } 681 }
682 } 682 }
683 683
684 void ChromeClientImpl::DispatchViewportPropertiesDidChange( 684 void ChromeClientImpl::DispatchViewportPropertiesDidChange(
685 const ViewportDescription& description) const { 685 const ViewportDescription& description) const {
686 web_view_->UpdatePageDefinedViewportConstraints(description); 686 web_view_->UpdatePageDefinedViewportConstraints(description);
687 } 687 }
688 688
689 void ChromeClientImpl::PrintDelegate(LocalFrame* frame) { 689 void ChromeClientImpl::PrintDelegate(LocalFrame* frame) {
690 NotifyPopupOpeningObservers();
690 if (web_view_->Client()) 691 if (web_view_->Client())
691 web_view_->Client()->PrintPage(WebLocalFrameImpl::FromFrame(frame)); 692 web_view_->Client()->PrintPage(WebLocalFrameImpl::FromFrame(frame));
692 } 693 }
693 694
694 ColorChooser* ChromeClientImpl::OpenColorChooser( 695 ColorChooser* ChromeClientImpl::OpenColorChooser(
695 LocalFrame* frame, 696 LocalFrame* frame,
696 ColorChooserClient* chooser_client, 697 ColorChooserClient* chooser_client,
697 const Color&) { 698 const Color&) {
698 NotifyPopupOpeningObservers(); 699 NotifyPopupOpeningObservers();
699 ColorChooserUIController* controller = nullptr; 700 ColorChooserUIController* controller = nullptr;
(...skipping 533 matching lines...) Expand 10 before | Expand all | Expand 10 after
1233 if (RuntimeEnabledFeatures::presentationEnabled()) 1234 if (RuntimeEnabledFeatures::presentationEnabled())
1234 PresentationController::ProvideTo(frame, client->PresentationClient()); 1235 PresentationController::ProvideTo(frame, client->PresentationClient());
1235 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) { 1236 if (RuntimeEnabledFeatures::audioOutputDevicesEnabled()) {
1236 ProvideAudioOutputDeviceClientTo(frame, 1237 ProvideAudioOutputDeviceClientTo(frame,
1237 new AudioOutputDeviceClientImpl(frame)); 1238 new AudioOutputDeviceClientImpl(frame));
1238 } 1239 }
1239 InstalledAppController::ProvideTo(frame, client->GetRelatedAppsFetcher()); 1240 InstalledAppController::ProvideTo(frame, client->GetRelatedAppsFetcher());
1240 } 1241 }
1241 1242
1242 } // namespace blink 1243 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/web/ChromeClientImpl.h ('k') | third_party/WebKit/Source/web/ValidationMessageClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698