Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 2834783002: window.print() should close form validation bubble. (Closed)

Created:
1 year, 2 months ago by tkent
Modified:
1 year, 2 months ago
Reviewers:
keishi
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

window.print() should close form validation bubble. Usually, window.open() deactivates the origin window and validation bubble on the origin window is closed. However, if window.print() is executed, it suspends message loop of the window, and deactivation isn't noticed until print dialog is closed. So, we need to close validation popup explicitly for window.print(). BUG=713686 Review-Url: https://codereview.chromium.org/2834783002 Cr-Commit-Position: refs/heads/master@{#466273} Committed: https://chromium.googlesource.com/chromium/src/+/9dbd356b0cc52911caef089b09de63572cd9e39f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M third_party/WebKit/Source/web/ChromeClientImpl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/ValidationMessageClientImpl.h View 3 chunks +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/ValidationMessageClientImpl.cpp View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
tkent
keishi, would you review this please? I couldn't find a way to write a test ...
1 year, 2 months ago (2017-04-21 06:23:09 UTC) #8
keishi
LGTM
1 year, 2 months ago (2017-04-21 06:29:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2834783002/1
1 year, 2 months ago (2017-04-21 06:33:31 UTC) #12
commit-bot: I haz the power
1 year, 2 months ago (2017-04-21 06:38:28 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/9dbd356b0cc52911caef089b09de...

Powered by Google App Engine
This is Rietveld 408576698