Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9217)

Unified Diff: chromecast/browser/devtools/cast_devtools_manager_delegate.cc

Issue 2833213002: DevTools: retain DTAH in all the targets to match their life time. (Closed)
Patch Set: cast test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/devtools/cast_devtools_manager_delegate.cc
diff --git a/chromecast/browser/devtools/cast_devtools_manager_delegate.cc b/chromecast/browser/devtools/cast_devtools_manager_delegate.cc
index dbc44aacf7e6f7385457a59bec52eb76d8685548..9a3467500b92d9543582648031914bb506585e9d 100644
--- a/chromecast/browser/devtools/cast_devtools_manager_delegate.cc
+++ b/chromecast/browser/devtools/cast_devtools_manager_delegate.cc
@@ -33,15 +33,14 @@ CastDevToolsManagerDelegate::~CastDevToolsManagerDelegate() {
g_devtools_manager_delegate = nullptr;
}
-bool CastDevToolsManagerDelegate::DiscoverTargets(
- const content::DevToolsAgentHost::DiscoveryCallback& callback) {
+content::DevToolsAgentHost::List
+CastDevToolsManagerDelegate::RemoteDebuggingTargets() {
content::DevToolsAgentHost::List enabled_hosts;
for (auto* web_contents : enabled_webcontents_) {
enabled_hosts.push_back(
content::DevToolsAgentHost::GetOrCreateFor(web_contents));
}
- callback.Run(enabled_hosts);
- return true;
+ return enabled_hosts;
}
void CastDevToolsManagerDelegate::EnableWebContentsForDebugging(

Powered by Google App Engine
This is Rietveld 408576698