Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8282)

Unified Diff: chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc

Issue 2833213002: DevTools: retain DTAH in all the targets to match their life time. (Closed)
Patch Set: cast test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc
diff --git a/chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc b/chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc
index f11c7bd7b03e871bea45c6f40bd07bbafe0431e6..b744de45727e144bb5699ead7758a0f099e914db 100644
--- a/chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc
+++ b/chromecast/browser/devtools/cast_devtools_manager_delegate_unittest.cc
@@ -60,24 +60,16 @@ TEST_F(CastDevToolsManagerDelegateTest, TestSingletonGetter) {
CastDevToolsManagerDelegate::GetInstance());
}
-TEST_F(CastDevToolsManagerDelegateTest, NoWebContents) {
- EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets(
- base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets,
- base::Unretained(this), WebContentsSet())));
-}
-
TEST_F(CastDevToolsManagerDelegateTest, DisabledWebContents) {
- EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets(
- base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets,
- base::Unretained(this), WebContentsSet())));
+ TestDiscoveredTargets(WebContentsSet(),
+ devtools_manager_delegate_->RemoteDebuggingTargets());
}
TEST_F(CastDevToolsManagerDelegateTest, EnabledWebContents) {
devtools_manager_delegate_->EnableWebContentsForDebugging(web_contents());
WebContentsSet enabled_web_contents({web_contents()});
- EXPECT_TRUE(devtools_manager_delegate_->DiscoverTargets(
- base::Bind(&CastDevToolsManagerDelegateTest::TestDiscoveredTargets,
- base::Unretained(this), enabled_web_contents)));
+ TestDiscoveredTargets(enabled_web_contents,
+ devtools_manager_delegate_->RemoteDebuggingTargets());
}
} // namespace shell
« no previous file with comments | « chromecast/browser/devtools/cast_devtools_manager_delegate.cc ('k') | content/browser/devtools/devtools_agent_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698