Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Side by Side Diff: chromecast/browser/devtools/cast_devtools_manager_delegate.cc

Issue 2833213002: DevTools: retain DTAH in all the targets to match their life time. (Closed)
Patch Set: cast test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chromecast/browser/devtools/cast_devtools_manager_delegate.h" 5 #include "chromecast/browser/devtools/cast_devtools_manager_delegate.h"
6 6
7 #include "base/macros.h" 7 #include "base/macros.h"
8 #include "build/build_config.h" 8 #include "build/build_config.h"
9 #include "chromecast/app/grit/shell_resources.h" 9 #include "chromecast/app/grit/shell_resources.h"
10 #include "content/public/browser/devtools_agent_host.h" 10 #include "content/public/browser/devtools_agent_host.h"
(...skipping 15 matching lines...) Expand all
26 CastDevToolsManagerDelegate::CastDevToolsManagerDelegate() { 26 CastDevToolsManagerDelegate::CastDevToolsManagerDelegate() {
27 DCHECK(!g_devtools_manager_delegate); 27 DCHECK(!g_devtools_manager_delegate);
28 g_devtools_manager_delegate = this; 28 g_devtools_manager_delegate = this;
29 } 29 }
30 30
31 CastDevToolsManagerDelegate::~CastDevToolsManagerDelegate() { 31 CastDevToolsManagerDelegate::~CastDevToolsManagerDelegate() {
32 DCHECK_EQ(this, g_devtools_manager_delegate); 32 DCHECK_EQ(this, g_devtools_manager_delegate);
33 g_devtools_manager_delegate = nullptr; 33 g_devtools_manager_delegate = nullptr;
34 } 34 }
35 35
36 bool CastDevToolsManagerDelegate::DiscoverTargets( 36 content::DevToolsAgentHost::List
37 const content::DevToolsAgentHost::DiscoveryCallback& callback) { 37 CastDevToolsManagerDelegate::RemoteDebuggingTargets() {
38 content::DevToolsAgentHost::List enabled_hosts; 38 content::DevToolsAgentHost::List enabled_hosts;
39 for (auto* web_contents : enabled_webcontents_) { 39 for (auto* web_contents : enabled_webcontents_) {
40 enabled_hosts.push_back( 40 enabled_hosts.push_back(
41 content::DevToolsAgentHost::GetOrCreateFor(web_contents)); 41 content::DevToolsAgentHost::GetOrCreateFor(web_contents));
42 } 42 }
43 callback.Run(enabled_hosts); 43 return enabled_hosts;
44 return true;
45 } 44 }
46 45
47 void CastDevToolsManagerDelegate::EnableWebContentsForDebugging( 46 void CastDevToolsManagerDelegate::EnableWebContentsForDebugging(
48 content::WebContents* web_contents) { 47 content::WebContents* web_contents) {
49 DCHECK(web_contents); 48 DCHECK(web_contents);
50 enabled_webcontents_.insert(web_contents); 49 enabled_webcontents_.insert(web_contents);
51 } 50 }
52 51
53 void CastDevToolsManagerDelegate::DisableWebContentsForDebugging( 52 void CastDevToolsManagerDelegate::DisableWebContentsForDebugging(
54 content::WebContents* web_contents) { 53 content::WebContents* web_contents) {
55 enabled_webcontents_.erase(web_contents); 54 enabled_webcontents_.erase(web_contents);
56 } 55 }
57 56
58 std::string CastDevToolsManagerDelegate::GetDiscoveryPageHTML() { 57 std::string CastDevToolsManagerDelegate::GetDiscoveryPageHTML() {
59 #if defined(OS_ANDROID) 58 #if defined(OS_ANDROID)
60 return std::string(); 59 return std::string();
61 #else 60 #else
62 return ResourceBundle::GetSharedInstance().GetRawDataResource( 61 return ResourceBundle::GetSharedInstance().GetRawDataResource(
63 IDR_CAST_SHELL_DEVTOOLS_DISCOVERY_PAGE).as_string(); 62 IDR_CAST_SHELL_DEVTOOLS_DISCOVERY_PAGE).as_string();
64 #endif 63 #endif
65 } 64 }
66 65
67 } // namespace shell 66 } // namespace shell
68 } // namespace chromecast 67 } // namespace chromecast
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698