chromecast/browser/devtools/cast_devtools_manager_delegate.h - Issue 2833213002: DevTools: retain DTAH in all the targets to match their life time.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromecast/browser/devtools/cast_devtools_manager_delegate.h

Issue 2833213002: DevTools: retain DTAH in all the targets to match their life time. (Closed)

Patch Set: cast test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromecast/browser/devtools/cast_devtools_manager_delegate.h

diff --git a/chromecast/browser/devtools/cast_devtools_manager_delegate.h b/chromecast/browser/devtools/cast_devtools_manager_delegate.h

index 73d2a5bae00c0e8ea58db4bea354a17937ce0544..c3e5c7865e843b96cda3e81c1e2eadad345a4a75 100644

--- a/chromecast/browser/devtools/cast_devtools_manager_delegate.h

+++ b/chromecast/browser/devtools/cast_devtools_manager_delegate.h

@@ -31,8 +31,7 @@ class CastDevToolsManagerDelegate : public content::DevToolsManagerDelegate {

void DisableWebContentsForDebugging(content::WebContents* web_contents);

// content::DevToolsManagerDelegate implementation.

- bool DiscoverTargets(

- const content::DevToolsAgentHost::DiscoveryCallback& callback) override;

+ content::DevToolsAgentHost::List RemoteDebuggingTargets() override;

std::string GetDiscoveryPageHTML() override;

private: