Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(464)

Issue 2833123002: Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/wtf (Closed)

Created:
3 years, 8 months ago by Hwanseung Lee
Modified:
3 years, 8 months ago
Reviewers:
tkent
CC:
blink-reviews, chromium-reviews, kinuko+watch
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/wtf Replace RELEASE_ASSERT, and ASSERT_NOT_REACHED with CHECK_op, and NOTREACHED respectively in third_party/WebKit/Source/platform/wtf. BUG=707661 Review-Url: https://codereview.chromium.org/2833123002 Cr-Commit-Position: refs/heads/master@{#466672} Committed: https://chromium.googlesource.com/chromium/src/+/177d44c2b478ca96d5cff47940509b578e4af697

Patch Set 1 : wtf #

Patch Set 2 : wtf #

Total comments: 1

Patch Set 3 : wtf #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -78 lines) Patch
M third_party/WebKit/Source/platform/wtf/AssertionsTest.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/Deque.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/HashTable.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/StackUtil.cpp View 1 2 4 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/TerminatedArrayBuilder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/Vector.h View 7 chunks +9 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/WTF.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/allocator/Partitions.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/dtoa/utils.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/AtomicStringTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/CString.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/StringConcatenate.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/StringImpl.h View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/StringImpl.cpp View 11 chunks +22 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/StringOperators.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/TextCodecUTF16.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/wtf/text/WTFString.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/typed_arrays/ArrayBuffer.h View 4 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/platform/wtf/typed_arrays/TypedArrayBase.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 31 (27 generated)
Hwanseung Lee
PTAL, thank you.
3 years, 8 months ago (2017-04-22 08:14:31 UTC) #24
tkent
lgtm if one comment is addressed. https://codereview.chromium.org/2833123002/diff/80001/third_party/WebKit/Source/platform/wtf/StackUtil.cpp File third_party/WebKit/Source/platform/wtf/StackUtil.cpp (right): https://codereview.chromium.org/2833123002/diff/80001/third_party/WebKit/Source/platform/wtf/StackUtil.cpp#newcode190 third_party/WebKit/Source/platform/wtf/StackUtil.cpp:190: CHECK_GT(thread_stack_size, (unsigned) 4 ...
3 years, 8 months ago (2017-04-23 23:00:45 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2833123002/100001
3 years, 8 months ago (2017-04-24 15:20:12 UTC) #28
commit-bot: I haz the power
3 years, 8 months ago (2017-04-24 17:38:13 UTC) #31
Message was sent while issue was closed.
Committed patchset #3 (id:100001) as
https://chromium.googlesource.com/chromium/src/+/177d44c2b478ca96d5cff4794050...

Powered by Google App Engine
This is Rietveld 408576698