third_party/WebKit/Source/platform/wtf/text/StringOperators.h - Issue 2833123002: Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/wtf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/wtf/text/StringOperators.h

Issue 2833123002: Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/wtf (Closed)

Patch Set: wtf Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/wtf/text/StringOperators.h

diff --git a/third_party/WebKit/Source/platform/wtf/text/StringOperators.h b/third_party/WebKit/Source/platform/wtf/text/StringOperators.h

index d7d8bba0804ba22d56dbf9b3425722fc028af5b0..98e6a0181ef3b92fcc2386395db0df1b88304a27 100644

--- a/third_party/WebKit/Source/platform/wtf/text/StringOperators.h

+++ b/third_party/WebKit/Source/platform/wtf/text/StringOperators.h

@@ -104,7 +104,8 @@ unsigned StringAppend<StringType1, StringType2>::length() const {

StringTypeAdapter<StringType2> adapter2(string2_);

unsigned total = adapter1.length() + adapter2.length();

// Guard against overflow.

- RELEASE_ASSERT(total >= adapter1.length() && total >= adapter2.length());

+ CHECK_GE(total, adapter1.length());

+ CHECK_GE(total, adapter2.length());

return total;

}