third_party/WebKit/Source/platform/wtf/text/CString.cpp - Issue 2833123002: Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/wtf

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/wtf/text/CString.cpp

Issue 2833123002: Replace ASSERT_NOT_REACHED, and RELEASE_ASSERT in platform/wtf (Closed)

Patch Set: wtf Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/wtf/text/CString.cpp

diff --git a/third_party/WebKit/Source/platform/wtf/text/CString.cpp b/third_party/WebKit/Source/platform/wtf/text/CString.cpp

index c175b535deb0557ef8bbfd077e4cd20c4eaf0174..46480f42f1c21609ebd629bf1ac84d7ce410c3cf 100644

--- a/third_party/WebKit/Source/platform/wtf/text/CString.cpp

+++ b/third_party/WebKit/Source/platform/wtf/text/CString.cpp

@@ -37,8 +37,7 @@ namespace WTF {

PassRefPtr<CStringImpl> CStringImpl::CreateUninitialized(size_t length,

char*& data) {

// TODO(esprehn): This doesn't account for the NUL.

- RELEASE_ASSERT(length <

- (numeric_limits<unsigned>::max() - sizeof(CStringImpl)));

+ CHECK_LT(length, (numeric_limits<unsigned>::max() - sizeof(CStringImpl)));

// The +1 is for the terminating NUL character.

size_t size = sizeof(CStringImpl) + length + 1;