Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 2831583003: Remove LayoutView from LayoutSelection::commit() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 months ago by yoichio
Modified:
5 months, 4 weeks ago
Reviewers:
tkent, yosin_UTC9
CC:
blink-reviews, blink-reviews-layout_chromium.org, chromium-reviews, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove LayoutView from LayoutSelection::commit() Since LayoutSelection::commit() doesn't use LayoutView any more, remove it. BUG=708453 Review-Url: https://codereview.chromium.org/2831583003 Cr-Commit-Position: refs/heads/master@{#466288} Committed: https://chromium.googlesource.com/chromium/src/+/39a09b97b317ad6c2417a3f19f6d3e32e356fe0a

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -33 lines) Patch
M third_party/WebKit/Source/core/editing/FrameSelection.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/LayoutSelection.h View 2 chunks +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/editing/LayoutSelection.cpp View 5 chunks +4 lines, -27 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutView.cpp View 1 chunk +2 lines, -1 line 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 24 (16 generated)
yoichio
5 months, 4 weeks ago (2017-04-21 04:29:01 UTC) #9
yosin_UTC9
lgtm
5 months, 4 weeks ago (2017-04-21 07:05:43 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831583003/20001
5 months, 4 weeks ago (2017-04-21 07:05:59 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/417336)
5 months, 4 weeks ago (2017-04-21 07:14:26 UTC) #16
yoichio
kent, could you take a look?
5 months, 4 weeks ago (2017-04-21 08:08:04 UTC) #18
tkent
lgtm
5 months, 4 weeks ago (2017-04-21 08:11:19 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831583003/20001
5 months, 4 weeks ago (2017-04-21 08:11:44 UTC) #21
commit-bot: I haz the power
5 months, 4 weeks ago (2017-04-21 08:38:44 UTC) #24
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/39a09b97b317ad6c2417a3f19f6d...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 81bcdb8aa