Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2831583003: Remove LayoutView from LayoutSelection::commit() (Closed)
Patch Set: update Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc. 3 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009 Apple Inc.
4 * All rights reserved. 4 * All rights reserved.
5 * 5 *
6 * This library is free software; you can redistribute it and/or 6 * This library is free software; you can redistribute it and/or
7 * modify it under the terms of the GNU Library General Public 7 * modify it under the terms of the GNU Library General Public
8 * License as published by the Free Software Foundation; either 8 * License as published by the Free Software Foundation; either
9 * version 2 of the License, or (at your option) any later version. 9 * version 2 of the License, or (at your option) any later version.
10 * 10 *
(...skipping 597 matching lines...) Expand 10 before | Expand all | Expand 10 after
608 quads.push_back(LocalToAbsoluteQuad( 608 quads.push_back(LocalToAbsoluteQuad(
609 FloatRect(FloatPoint(), FloatSize(Layer()->size())), mode)); 609 FloatRect(FloatPoint(), FloatSize(Layer()->size())), mode));
610 } 610 }
611 611
612 void LayoutView::ClearSelection() { 612 void LayoutView::ClearSelection() {
613 frame_view_->GetFrame().Selection().ClearLayoutSelection(); 613 frame_view_->GetFrame().Selection().ClearLayoutSelection();
614 } 614 }
615 615
616 void LayoutView::CommitPendingSelection() { 616 void LayoutView::CommitPendingSelection() {
617 TRACE_EVENT0("blink", "LayoutView::commitPendingSelection"); 617 TRACE_EVENT0("blink", "LayoutView::commitPendingSelection");
618 frame_view_->GetFrame().Selection().CommitAppearanceIfNeeded(*this); 618 DCHECK(!NeedsLayout());
619 frame_view_->GetFrame().Selection().CommitAppearanceIfNeeded();
619 } 620 }
620 621
621 bool LayoutView::ShouldUsePrintingLayout() const { 622 bool LayoutView::ShouldUsePrintingLayout() const {
622 if (!GetDocument().Printing() || !frame_view_) 623 if (!GetDocument().Printing() || !frame_view_)
623 return false; 624 return false;
624 return frame_view_->GetFrame().ShouldUsePrintingLayout(); 625 return frame_view_->GetFrame().ShouldUsePrintingLayout();
625 } 626 }
626 627
627 LayoutRect LayoutView::ViewRect() const { 628 LayoutRect LayoutView::ViewRect() const {
628 if (ShouldUsePrintingLayout()) 629 if (ShouldUsePrintingLayout())
(...skipping 184 matching lines...) Expand 10 before | Expand all | Expand 10 after
813 // Frame scroll corner is painted using LayoutView as the display item client. 814 // Frame scroll corner is painted using LayoutView as the display item client.
814 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled() && 815 if (!RuntimeEnabledFeatures::rootLayerScrollingEnabled() &&
815 (GetFrameView()->HorizontalScrollbar() || 816 (GetFrameView()->HorizontalScrollbar() ||
816 GetFrameView()->VerticalScrollbar())) 817 GetFrameView()->VerticalScrollbar()))
817 return false; 818 return false;
818 819
819 return LayoutBlockFlow::PaintedOutputOfObjectHasNoEffectRegardlessOfSize(); 820 return LayoutBlockFlow::PaintedOutputOfObjectHasNoEffectRegardlessOfSize();
820 } 821 }
821 822
822 } // namespace blink 823 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698