third_party/WebKit/Source/core/layout/LayoutView.cpp - Issue 2831583003: Remove LayoutView from LayoutSelection::commit()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 2831583003: Remove LayoutView from LayoutSelection::commit() (Closed)

Patch Set: update Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutView.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutView.cpp b/third_party/WebKit/Source/core/layout/LayoutView.cpp

index 5121862a94ec7c485a5898932a926e6544e7ec2a..343bec145d51e2d224f9cf1f4b36e1d2322d635b 100644

--- a/third_party/WebKit/Source/core/layout/LayoutView.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutView.cpp

@@ -615,7 +615,8 @@ void LayoutView::ClearSelection() {

void LayoutView::CommitPendingSelection() {

TRACE_EVENT0("blink", "LayoutView::commitPendingSelection");

- frame_view_->GetFrame().Selection().CommitAppearanceIfNeeded(*this);

+ DCHECK(!NeedsLayout());

+ frame_view_->GetFrame().Selection().CommitAppearanceIfNeeded();

}

bool LayoutView::ShouldUsePrintingLayout() const {

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutObject.cpp ('k') | no next file » | no next file with comments »