Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2831033002: Use unique_ptr for Platform::CreateURLLoader (Closed)

Created:
3 years, 8 months ago by yhirano
Modified:
3 years, 8 months ago
Reviewers:
kinuko
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, tyoshino+watch_chromium.org, jam, loading-reviews_chromium.org, dglazkov+blink, darin-cc_chromium.org, gavinp+loader_chromium.org, blink-reviews, loading-reviews+fetch_chromium.org, kinuko+watch, Nate Chapin, blink-reviews-api_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use unique_ptr for Platform::CreateURLLoader BUG=None Review-Url: https://codereview.chromium.org/2831033002 Cr-Commit-Position: refs/heads/master@{#465908} Committed: https://chromium.googlesource.com/chromium/src/+/f9f882493c6285711f95b88648974e1641168c28

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -26 lines) Patch
M content/ppapi_plugin/ppapi_blink_platform_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/ppapi_plugin/ppapi_blink_platform_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/fetchers/resource_fetcher_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/renderer_blink_platform_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/test/test_blink_web_unit_test_support.h View 1 chunk +1 line, -1 line 0 comments Download
M content/test/test_blink_web_unit_test_support.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/loader/PingLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/fetch/ResourceLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/testing/FetchTestingPlatformSupport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/loader/testing/FetchTestingPlatformSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/TestingPlatformSupport.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/weburl_loader_mock.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/weburl_loader_mock.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.h View 1 chunk +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/testing/weburl_loader_mock_factory_impl.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/public/platform/Platform.h View 3 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/public/platform/WebURLLoaderMockFactory.h View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
yhirano
3 years, 8 months ago (2017-04-20 04:10:36 UTC) #4
kinuko
Yeah was about to create the same CL.
3 years, 8 months ago (2017-04-20 04:13:20 UTC) #5
kinuko
lgtm
3 years, 8 months ago (2017-04-20 04:14:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2831033002/1
3 years, 8 months ago (2017-04-20 04:15:28 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 05:56:11 UTC) #12
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/f9f882493c6285711f95b8864897...

Powered by Google App Engine
This is Rietveld 408576698