Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Side by Side Diff: third_party/WebKit/public/platform/Platform.h

Issue 2831033002: Use unique_ptr for Platform::CreateURLLoader (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
46 #include "WebGestureDevice.h" 46 #include "WebGestureDevice.h"
47 #include "WebLocalizedString.h" 47 #include "WebLocalizedString.h"
48 #include "WebMessagePortChannel.h" 48 #include "WebMessagePortChannel.h"
49 #include "WebPlatformEventType.h" 49 #include "WebPlatformEventType.h"
50 #include "WebSize.h" 50 #include "WebSize.h"
51 #include "WebSpeechSynthesizer.h" 51 #include "WebSpeechSynthesizer.h"
52 #include "WebStorageQuotaCallbacks.h" 52 #include "WebStorageQuotaCallbacks.h"
53 #include "WebStorageQuotaType.h" 53 #include "WebStorageQuotaType.h"
54 #include "WebString.h" 54 #include "WebString.h"
55 #include "WebURLError.h" 55 #include "WebURLError.h"
56 #include "WebURLLoader.h"
56 #include "WebVector.h" 57 #include "WebVector.h"
57 #include "base/metrics/user_metrics_action.h" 58 #include "base/metrics/user_metrics_action.h"
58 #include "cc/resources/shared_bitmap.h" 59 #include "cc/resources/shared_bitmap.h"
59 #include "cc/surfaces/frame_sink_id.h" 60 #include "cc/surfaces/frame_sink_id.h"
60 #include "mojo/public/cpp/system/message_pipe.h" 61 #include "mojo/public/cpp/system/message_pipe.h"
61 62
62 namespace device { 63 namespace device {
63 class Gamepads; 64 class Gamepads;
64 } 65 }
65 66
(...skipping 54 matching lines...) Expand 10 before | Expand all | Expand 10 after
120 class WebSecurityOrigin; 121 class WebSecurityOrigin;
121 class WebServiceWorkerCacheStorage; 122 class WebServiceWorkerCacheStorage;
122 class WebSpeechSynthesizer; 123 class WebSpeechSynthesizer;
123 class WebSpeechSynthesizerClient; 124 class WebSpeechSynthesizerClient;
124 class WebStorageNamespace; 125 class WebStorageNamespace;
125 class WebSyncProvider; 126 class WebSyncProvider;
126 struct WebFloatPoint; 127 struct WebFloatPoint;
127 class WebThemeEngine; 128 class WebThemeEngine;
128 class WebThread; 129 class WebThread;
129 class WebTrialTokenValidator; 130 class WebTrialTokenValidator;
130 class WebURLLoader;
131 class WebURLLoaderMockFactory; 131 class WebURLLoaderMockFactory;
132 class WebURLResponse; 132 class WebURLResponse;
133 class WebURLResponse; 133 class WebURLResponse;
134 struct WebSize; 134 struct WebSize;
135 135
136 class BLINK_PLATFORM_EXPORT Platform { 136 class BLINK_PLATFORM_EXPORT Platform {
137 public: 137 public:
138 // HTML5 Database ------------------------------------------------------ 138 // HTML5 Database ------------------------------------------------------
139 139
140 #ifdef WIN32 140 #ifdef WIN32
(...skipping 186 matching lines...) Expand 10 before | Expand all | Expand 10 after
327 virtual void CreateMessageChannel( 327 virtual void CreateMessageChannel(
328 std::unique_ptr<WebMessagePortChannel>* channel1, 328 std::unique_ptr<WebMessagePortChannel>* channel1,
329 std::unique_ptr<WebMessagePortChannel>* channel2) { 329 std::unique_ptr<WebMessagePortChannel>* channel2) {
330 *channel1 = nullptr; 330 *channel1 = nullptr;
331 *channel2 = nullptr; 331 *channel2 = nullptr;
332 } 332 }
333 333
334 // Network ------------------------------------------------------------- 334 // Network -------------------------------------------------------------
335 335
336 // Returns a new WebURLLoader instance. 336 // Returns a new WebURLLoader instance.
337 virtual WebURLLoader* CreateURLLoader() { return nullptr; } 337 virtual std::unique_ptr<WebURLLoader> CreateURLLoader() { return nullptr; }
338 338
339 // May return null. 339 // May return null.
340 virtual WebPrescientNetworking* PrescientNetworking() { return nullptr; } 340 virtual WebPrescientNetworking* PrescientNetworking() { return nullptr; }
341 341
342 // Returns the User-Agent string. 342 // Returns the User-Agent string.
343 virtual WebString UserAgent() { return WebString(); } 343 virtual WebString UserAgent() { return WebString(); }
344 344
345 // A suggestion to cache this metadata in association with this URL. 345 // A suggestion to cache this metadata in association with this URL.
346 virtual void CacheMetadata(const WebURL&, 346 virtual void CacheMetadata(const WebURL&,
347 int64_t response_time, 347 int64_t response_time,
(...skipping 369 matching lines...) Expand 10 before | Expand all | Expand 10 after
717 protected: 717 protected:
718 Platform(); 718 Platform();
719 virtual ~Platform() {} 719 virtual ~Platform() {}
720 720
721 WebThread* main_thread_; 721 WebThread* main_thread_;
722 }; 722 };
723 723
724 } // namespace blink 724 } // namespace blink
725 725
726 #endif 726 #endif
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698