content/renderer/fetchers/resource_fetcher_impl.cc - Issue 2831033002: Use unique_ptr for Platform::CreateURLLoader

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/fetchers/resource_fetcher_impl.cc

Issue 2831033002: Use unique_ptr for Platform::CreateURLLoader (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/renderer/fetchers/resource_fetcher_impl.cc

diff --git a/content/renderer/fetchers/resource_fetcher_impl.cc b/content/renderer/fetchers/resource_fetcher_impl.cc

index 9abded928d92bf82f3cef6d8eb42bbe299a5caf9..25c26768eae0cec0613482ef826ccad7afc04911 100644

--- a/content/renderer/fetchers/resource_fetcher_impl.cc

+++ b/content/renderer/fetchers/resource_fetcher_impl.cc

@@ -184,7 +184,7 @@ void ResourceFetcherImpl::Start(

client_.reset(new ClientImpl(this, callback));

- loader_.reset(blink::Platform::Current()->CreateURLLoader());

+ loader_ = blink::Platform::Current()->CreateURLLoader();

loader_->LoadAsynchronously(request_, client_.get());

// No need to hold on to the request; reset it now.