Remove the concept of 'nonproperties' from ComputedStyle generator.

Remove the concept of 'nonproperties' from ComputedStyle generator.

When we generate ComputedStyle, we differentiate between properties
(which are meant to correspond to CSS properties) and nonproperties
(everything else). However, this terminology is confusing:

- Some nonproperties are derived from real CSS properties (e.g.
  hasSimpleUnderline).
- The generator code contains a lot of "for property_ in nonproperties"
  which is quite confusing.
- The name does not reveal the actual difference between properties
  and nonproperties in terms of code generation.

This patch removes the field role of 'nonproperty' in favour of the
parameter 'has_custom_compare_and_copy'. So there are only two field
roles: 'property' (which includes flags like 'unique' and 'emptyState')
and 'inherited_flag'.

BUG=628043
Review-Url: https://codereview.chromium.org/2830983003
Cr-Commit-Position: refs/heads/master@{#468279}
Committed: https://chromium.googlesource.com/chromium/src/+/a7bdae0c8fc2af8615d676c546cef735a131a8f1

[shend, 2017-04-20 04:09:55]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-20 04:10:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-20 05:52:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-20 05:52:09]

Dry run: This issue passed the CQ dry run.

[shend, 2017-04-21 03:54:36]

shend@chromium.org changed reviewers:
+ nainar@chromium.org

[shend, 2017-04-21 03:54:37]

Hi Naina, PTAL :)

[nainar, 2017-04-21 03:59:26]

lgtm

[shend, 2017-04-21 04:05:06]

shend@chromium.org changed reviewers:
+ alancutter@chromium.org

[shend, 2017-04-21 04:05:06]

Hi Alan, PTAL :)

[alancutter (OOO until 2018), 2017-04-21 05:25:25]

lgtm

[shend, 2017-04-28 05:26:48]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-28 05:27:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 07:08:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 07:08:32]

Dry run: This issue passed the CQ dry run.

[shend, 2017-04-30 22:15:15]

The CQ bit was checked by shend@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-30 22:15:22]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-30 23:33:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-30 23:33:30]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[shend, 2017-05-01 03:33:57]

The CQ bit was checked by shend@chromium.org

[shend, 2017-05-01 03:33:58]

The patchset sent to the CQ was uploaded after l-g-t-m from nainar@chromium.org,
alancutter@chromium.org
Link to the patchset: https://codereview.chromium.org/2830983003/#ps20001
(title: "Rebase")

[commit-bot: I haz the power, 2017-05-01 03:34:12]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 04:12:56]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493609637966900,
"parent_rev": "a4e8fc5aeabab79dd84a7ced4b7c433a428864a5", "commit_rev":
"a7bdae0c8fc2af8615d676c546cef735a131a8f1"}

[commit-bot: I haz the power, 2017-05-01 04:13:46]

Description was changed from

==========
Remove the concept of 'nonproperties' from ComputedStyle generator.

When we generate ComputedStyle, we differentiate between properties
(which are meant to correspond to CSS properties) and nonproperties
(everything else). However, this terminology is confusing:

- Some nonproperties are derived from real CSS properties (e.g.
  hasSimpleUnderline).
- The generator code contains a lot of "for property_ in nonproperties"
  which is quite confusing.
- The name does not reveal the actual difference between properties
  and nonproperties in terms of code generation.

This patch removes the field role of 'nonproperty' in favour of the
parameter 'has_custom_compare_and_copy'. So there are only two field
roles: 'property' (which includes flags like 'unique' and 'emptyState')
and 'inherited_flag'.

BUG=628043
==========

to

==========
Remove the concept of 'nonproperties' from ComputedStyle generator.

When we generate ComputedStyle, we differentiate between properties
(which are meant to correspond to CSS properties) and nonproperties
(everything else). However, this terminology is confusing:

- Some nonproperties are derived from real CSS properties (e.g.
  hasSimpleUnderline).
- The generator code contains a lot of "for property_ in nonproperties"
  which is quite confusing.
- The name does not reveal the actual difference between properties
  and nonproperties in terms of code generation.

This patch removes the field role of 'nonproperty' in favour of the
parameter 'has_custom_compare_and_copy'. So there are only two field
roles: 'property' (which includes flags like 'unique' and 'emptyState')
and 'inherited_flag'.

BUG=628043

Review-Url: https://codereview.chromium.org/2830983003
Cr-Commit-Position: refs/heads/master@{#468279}
Committed:
https://chromium.googlesource.com/chromium/src/+/a7bdae0c8fc2af8615d676c546ce...
==========

[commit-bot: I haz the power, 2017-05-01 04:13:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a7bdae0c8fc2af8615d676c546ce...