third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl - Issue 2830983003: Remove the concept of 'nonproperties' from ComputedStyle generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

Issue 2830983003: Remove the concept of 'nonproperties' from ComputedStyle generator. (Closed)

Patch Set: Rebase Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/build/scripts/make_computed_style_base.py ('k') | third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.h.tmpl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

diff --git a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

index e28efac956d4d2f552fd7210d5f3f19659ee7a4c..6f8132fe70b358ca26726b210874ee2cb79aad69 100644

--- a/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

+++ b/third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

@@ -25,6 +25,7 @@ ASSERT_SIZE(ComputedStyleBase, SameSizeAsComputedStyleBase);

void ComputedStyleBase::InheritFrom(const ComputedStyleBase& other,

IsAtShadowBoundary isAtShadowBoundary) {

{{fieldwise_copy(computed_style, computed_style.all_fields

+ |selectattr("is_property")

|selectattr("is_inherited")

|list

)|indent(2)}}

@@ -33,7 +34,7 @@ void ComputedStyleBase::InheritFrom(const ComputedStyleBase& other,

void ComputedStyleBase::CopyNonInheritedFromCached(

const ComputedStyleBase& other) {

{{fieldwise_copy(computed_style, computed_style.all_fields

- |rejectattr("is_nonproperty")

+ |rejectattr("has_custom_compare_and_copy")

|rejectattr("is_inherited")

|list

)|indent(2)}}