Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Side by Side Diff: third_party/WebKit/Source/build/scripts/templates/ComputedStyleBase.cpp.tmpl

Issue 2830983003: Remove the concept of 'nonproperties' from ComputedStyle generator. (Closed)
Patch Set: Rebase Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 {% from 'macros.tmpl' import license %} 1 {% from 'macros.tmpl' import license %}
2 {% from 'fields/field.tmpl' import getter_expression, setter_expression, fieldwi se_copy %} 2 {% from 'fields/field.tmpl' import getter_expression, setter_expression, fieldwi se_copy %}
3 {{license()}} 3 {{license()}}
4 4
5 #include "core/ComputedStyleBase.h" 5 #include "core/ComputedStyleBase.h"
6 #include "platform/wtf/SizeAssertions.h" 6 #include "platform/wtf/SizeAssertions.h"
7 7
8 namespace blink { 8 namespace blink {
9 9
10 struct SameSizeAsComputedStyleBase { 10 struct SameSizeAsComputedStyleBase {
11 {% if computed_style.subgroups is defined %} 11 {% if computed_style.subgroups is defined %}
12 void* dataRefs[{{computed_style.subgroups|length}}]; 12 void* dataRefs[{{computed_style.subgroups|length}}];
13 {% endif %} 13 {% endif %}
14 {% for field in computed_style.fields|rejectattr("is_bit_field") %} 14 {% for field in computed_style.fields|rejectattr("is_bit_field") %}
15 {{field.type_name}} {{field.name}}}; 15 {{field.type_name}} {{field.name}}};
16 {% endfor %} 16 {% endfor %}
17 unsigned m_bit_fields[{{computed_style.num_32_bit_words_for_bit_fields}}]; 17 unsigned m_bit_fields[{{computed_style.num_32_bit_words_for_bit_fields}}];
18 }; 18 };
19 19
20 // If this fails, the packing algorithm in make_computed_style_base.py has 20 // If this fails, the packing algorithm in make_computed_style_base.py has
21 // failed to produce the optimal packed size. To fix, update the algorithm to 21 // failed to produce the optimal packed size. To fix, update the algorithm to
22 // ensure that the buckets are placed so that each takes up at most 1 word. 22 // ensure that the buckets are placed so that each takes up at most 1 word.
23 ASSERT_SIZE(ComputedStyleBase, SameSizeAsComputedStyleBase); 23 ASSERT_SIZE(ComputedStyleBase, SameSizeAsComputedStyleBase);
24 24
25 void ComputedStyleBase::InheritFrom(const ComputedStyleBase& other, 25 void ComputedStyleBase::InheritFrom(const ComputedStyleBase& other,
26 IsAtShadowBoundary isAtShadowBoundary) { 26 IsAtShadowBoundary isAtShadowBoundary) {
27 {{fieldwise_copy(computed_style, computed_style.all_fields 27 {{fieldwise_copy(computed_style, computed_style.all_fields
28 |selectattr("is_property")
28 |selectattr("is_inherited") 29 |selectattr("is_inherited")
29 |list 30 |list
30 )|indent(2)}} 31 )|indent(2)}}
31 } 32 }
32 33
33 void ComputedStyleBase::CopyNonInheritedFromCached( 34 void ComputedStyleBase::CopyNonInheritedFromCached(
34 const ComputedStyleBase& other) { 35 const ComputedStyleBase& other) {
35 {{fieldwise_copy(computed_style, computed_style.all_fields 36 {{fieldwise_copy(computed_style, computed_style.all_fields
36 |rejectattr("is_nonproperty") 37 |rejectattr("has_custom_compare_and_copy")
37 |rejectattr("is_inherited") 38 |rejectattr("is_inherited")
38 |list 39 |list
39 )|indent(2)}} 40 )|indent(2)}}
40 } 41 }
41 42
42 void ComputedStyleBase::PropagateIndependentInheritedProperties( 43 void ComputedStyleBase::PropagateIndependentInheritedProperties(
43 const ComputedStyleBase& parentStyle) { 44 const ComputedStyleBase& parentStyle) {
44 {% for field in computed_style.all_fields if field.is_property and field.is_in dependent %} 45 {% for field in computed_style.all_fields if field.is_property and field.is_in dependent %}
45 if ({{field.is_inherited_method_name}}()) 46 if ({{field.is_inherited_method_name}}())
46 {{setter_expression(field)}} = parentStyle.{{getter_expression(field)}}; 47 {{setter_expression(field)}} = parentStyle.{{getter_expression(field)}};
47 {% endfor %} 48 {% endfor %}
48 } 49 }
49 50
50 } // namespace blink 51 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698