Fix sending autofill votes for sign-in forms.

Fix sending autofill votes for sign-in forms.

On CL https://codereview.chromium.org/2796873002/ a sending of autofill votes for sing-in forms was implemented, but |available_field_types_| doesn't contain PASSWORD type, that makes that the server skips such forms as invalid. This CL adds PASSWORD type for sign-in form uploads.

BUG=713688, 699530
Review-Url: https://codereview.chromium.org/2830303002
Cr-Commit-Position: refs/heads/master@{#466621}
Committed: https://chromium.googlesource.com/chromium/src/+/2366977b83a1eb2ce167821d7d1d9e084bd602fc

[dvadym, 2017-04-21 10:00:03]

Description was changed from

==========
Fix sending username votes

BUG=713688
==========

to

==========
Fix sending autofill votes for sign-in forms.

On CL https://codereview.chromium.org/2796873002/ a sending of autofill votes
for sing-in forms was implemented, but |available_field_types_| doesn't contain
PASSWORD type, that makes that the server skips such forms as invalid. This CL
adds PASSWORD type for sign-in form uploads.

BUG=713688
==========

[dvadym, 2017-04-21 10:00:32]

dvadym@chromium.org changed reviewers:
+ rogerm@chromium.org

[dvadym, 2017-04-21 10:00:33]

Hi Roger,

 could you please review this CL?

Regards,
Vadym

[dvadym, 2017-04-21 10:01:46]

Description was changed from

==========
Fix sending autofill votes for sign-in forms.

On CL https://codereview.chromium.org/2796873002/ a sending of autofill votes
for sing-in forms was implemented, but |available_field_types_| doesn't contain
PASSWORD type, that makes that the server skips such forms as invalid. This CL
adds PASSWORD type for sign-in form uploads.

BUG=713688
==========

to

==========
Fix sending autofill votes for sign-in forms.

On CL https://codereview.chromium.org/2796873002/ a sending of autofill votes
for sing-in forms was implemented, but |available_field_types_| doesn't contain
PASSWORD type, that makes that the server skips such forms as invalid. This CL
adds PASSWORD type for sign-in form uploads.

BUG=713688, 699530
==========

[Roger McFarlane (Chromium), 2017-04-21 15:48:33]

nit: 

Can you also update FormStructure::EncodeUploadRequest (form_structure.cc:391)
to extract the verification loop to a helper function:

// something like...
namespace {
bool AllTypesCaptured(
    const FormStructure& form,
    const ServerFieldTypeSet& contained_types) {
  for (const auto* field : form) {
    for (const auto& type : field->possible_types()) {
      if (type != UNKNOWN_TYPE && type != EMPTY_TYPE &&
          contained_types.count(type) == 0) {
        return false;
      }
    }
  }
  return true;
}
}

Then ...

// In EncodeUploadRequest...
DCHECK(
    AllTypesAccountedFor(*this, available_field_types));

[Roger McFarlane (Chromium), 2017-04-21 15:51:43]

otherwise, LGTM

PS - why only run select try bots instead of a full git cl try?

[dvadym, 2017-04-24 11:56:11]

The CQ bit was checked by dvadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 11:56:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dvadym, 2017-04-24 12:00:11]

The CQ bit was checked by dvadym@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 12:00:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dvadym, 2017-04-24 12:04:49]

Thanks for review Roger! I've extracted checking in a separate function as you
recommended.

> PS - why only run select try bots instead of a full git cl try?
It's just a habit, I try not to spend extra resources for running many bots,
especially when a change unlikely affects OS that are not covered in the chosen
bots.

[dvadym, 2017-04-24 12:07:36]

The CQ bit was unchecked by dvadym@chromium.org

[dvadym, 2017-04-24 12:07:36]

The CQ bit was checked by dvadym@chromium.org

[dvadym, 2017-04-24 12:07:37]

The patchset sent to the CQ was uploaded after l-g-t-m from rogerm@chromium.org
Link to the patchset: https://codereview.chromium.org/2830303002/#ps40001
(title: "Comments added")

[commit-bot: I haz the power, 2017-04-24 12:07:48]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 13:10:23]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493035656776810,
"parent_rev": "3323cb816ab5d6cf0b0b6026bf98d58b1aa92402", "commit_rev":
"2366977b83a1eb2ce167821d7d1d9e084bd602fc"}

[commit-bot: I haz the power, 2017-04-24 13:10:33]

Description was changed from

==========
Fix sending autofill votes for sign-in forms.

On CL https://codereview.chromium.org/2796873002/ a sending of autofill votes
for sing-in forms was implemented, but |available_field_types_| doesn't contain
PASSWORD type, that makes that the server skips such forms as invalid. This CL
adds PASSWORD type for sign-in form uploads.

BUG=713688, 699530
==========

to

==========
Fix sending autofill votes for sign-in forms.

On CL https://codereview.chromium.org/2796873002/ a sending of autofill votes
for sing-in forms was implemented, but |available_field_types_| doesn't contain
PASSWORD type, that makes that the server skips such forms as invalid. This CL
adds PASSWORD type for sign-in form uploads.

BUG=713688, 699530

Review-Url: https://codereview.chromium.org/2830303002
Cr-Commit-Position: refs/heads/master@{#466621}
Committed:
https://chromium.googlesource.com/chromium/src/+/2366977b83a1eb2ce167821d7d1d...
==========

[commit-bot: I haz the power, 2017-04-24 13:10:35]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/2366977b83a1eb2ce167821d7d1d...