Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: components/autofill/core/browser/autofill_manager.cc

Issue 2830303002: Fix sending autofill votes for sign-in forms. (Closed)
Patch Set: Comments added Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/autofill/core/browser/autofill_manager.h" 5 #include "components/autofill/core/browser/autofill_manager.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <algorithm> 10 #include <algorithm>
(...skipping 1422 matching lines...) Expand 10 before | Expand all | Expand 10 after
1433 std::string form_signature = submitted_form.FormSignatureAsStr(); 1433 std::string form_signature = submitted_form.FormSignatureAsStr();
1434 for (const std::string& cur_sig : autofilled_form_signatures_) { 1434 for (const std::string& cur_sig : autofilled_form_signatures_) {
1435 if (cur_sig == form_signature) { 1435 if (cur_sig == form_signature) {
1436 was_autofilled = true; 1436 was_autofilled = true;
1437 break; 1437 break;
1438 } 1438 }
1439 } 1439 }
1440 1440
1441 ServerFieldTypeSet non_empty_types; 1441 ServerFieldTypeSet non_empty_types;
1442 personal_data_->GetNonEmptyTypes(&non_empty_types); 1442 personal_data_->GetNonEmptyTypes(&non_empty_types);
1443 if (submitted_form.is_signin_upload())
1444 non_empty_types.insert(PASSWORD);
1443 1445
1444 download_manager_->StartUploadRequest( 1446 download_manager_->StartUploadRequest(
1445 submitted_form, was_autofilled, non_empty_types, 1447 submitted_form, was_autofilled, non_empty_types,
1446 std::string() /* login_form_signature */, observed_submission); 1448 std::string() /* login_form_signature */, observed_submission);
1447 } 1449 }
1448 1450
1449 void AutofillManager::Reset() { 1451 void AutofillManager::Reset() {
1450 // Note that upload_request_ is not reset here because the prompt to 1452 // Note that upload_request_ is not reset here because the prompt to
1451 // save a card is shown after page navigation. 1453 // save a card is shown after page navigation.
1452 ProcessPendingFormForUpload(); 1454 ProcessPendingFormForUpload();
(...skipping 795 matching lines...) Expand 10 before | Expand all | Expand 10 after
2248 } 2250 }
2249 #endif // ENABLE_FORM_DEBUG_DUMP 2251 #endif // ENABLE_FORM_DEBUG_DUMP
2250 2252
2251 void AutofillManager::LogCardUploadDecisionUkm( 2253 void AutofillManager::LogCardUploadDecisionUkm(
2252 AutofillMetrics::CardUploadDecisionMetric upload_decision) { 2254 AutofillMetrics::CardUploadDecisionMetric upload_decision) {
2253 AutofillMetrics::LogCardUploadDecisionUkm( 2255 AutofillMetrics::LogCardUploadDecisionUkm(
2254 client_->GetUkmService(), pending_upload_request_url_, upload_decision); 2256 client_->GetUkmService(), pending_upload_request_url_, upload_decision);
2255 } 2257 }
2256 2258
2257 } // namespace autofill 2259 } // namespace autofill
OLDNEW
« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698