components/autofill/core/browser/autofill_manager.cc - Issue 2830303002: Fix sending autofill votes for sign-in forms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/core/browser/autofill_manager.cc

Issue 2830303002: Fix sending autofill votes for sign-in forms. (Closed)

Patch Set: Comments added Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/autofill/core/browser/autofill_manager.cc

diff --git a/components/autofill/core/browser/autofill_manager.cc b/components/autofill/core/browser/autofill_manager.cc

index 933b7c5dd41a1549fca6c368a1235d2e756ba4c3..e1c38469243bdb886bea2d6974f0e0e62ca695a6 100644

--- a/components/autofill/core/browser/autofill_manager.cc

+++ b/components/autofill/core/browser/autofill_manager.cc

@@ -1440,6 +1440,8 @@ void AutofillManager::UploadFormData(const FormStructure& submitted_form,

ServerFieldTypeSet non_empty_types;

personal_data_->GetNonEmptyTypes(&non_empty_types);

+ if (submitted_form.is_signin_upload())

+ non_empty_types.insert(PASSWORD);

download_manager_->StartUploadRequest(

submitted_form, was_autofilled, non_empty_types,

« no previous file with comments | « no previous file | components/autofill/core/browser/autofill_manager_unittest.cc » ('j') | no next file with comments »