Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(18)

Issue 2830233002: [DMC #1.914] Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersForNode() (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months ago by rlanday
Modified:
5 months ago
Reviewers:
tkent, yosin_UTC9, Xiaocheng
CC:
blink-reviews, blink-reviews-dom_chromium.org, chromium-reviews, dglazkov+blink, eae+blinkwatch, groby+blinkspell_chromium.org, rwlbuis, sof, timvolodine, Xiaocheng
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename DocumentMarkerController::RemoveMarkers() to RemoveMarkersForNode() yosin pointed out that it's confusing to have so many methods named RemoveMarkers(): https://codereview.chromium.org/2820633002#msg30 This is the fourth of several renaming CLs I'm going to upload BUG=707867 Review-Url: https://codereview.chromium.org/2830233002 Cr-Commit-Position: refs/heads/master@{#466534} Committed: https://chromium.googlesource.com/chromium/src/+/bda3d4871655a1cb5121cde488845d9b968eda6c

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Remove dependency #

Patch Set 4 : Rebase, remove dep #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M third_party/WebKit/Source/core/dom/Node.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/editing/spellcheck/SpellChecker.cpp View 1 2 3 1 chunk +4 lines, -2 lines 0 comments Download
Commit queue not available (can’t edit this change).

Messages

Total messages: 24 (16 generated)
rlanday
5 months ago (2017-04-21 03:49:57 UTC) #3
Xiaocheng
lgtm
5 months ago (2017-04-21 05:26:29 UTC) #6
yosin_UTC9
lgtm
5 months ago (2017-04-21 08:27:32 UTC) #11
yosin_UTC9
+tkent@ for core/dom/Node.cpp chagnes
5 months ago (2017-04-21 08:32:59 UTC) #13
tkent
lgtm
5 months ago (2017-04-21 08:35:30 UTC) #14
commit-bot: I haz the power
This CL has an open dependency (Issue 2836563002 Patch 40001). Please resolve the dependency and ...
5 months ago (2017-04-21 08:40:08 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2830233002/60001
5 months ago (2017-04-21 23:38:40 UTC) #21
commit-bot: I haz the power
5 months ago (2017-04-22 03:39:54 UTC) #24
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/bda3d4871655a1cb5121cde48884...
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b