Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 2829783003: bluetooth-internals: Fix flaky test (Closed)

Created:
3 years, 8 months ago by ortuno
Modified:
3 years, 8 months ago
Reviewers:
dpapad
CC:
chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

bluetooth-internals: Fix flaky test The test was not returning the promise so the test finished without actually executing the rest of the test. BUG=707530 Review-Url: https://codereview.chromium.org/2829783003 Cr-Commit-Position: refs/heads/master@{#465880} Committed: https://chromium.googlesource.com/chromium/src/+/d8adf4fbe2475512e378443279017eadfd0dc68a

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M chrome/test/data/webui/bluetooth_internals_browsertest.js View 2 chunks +2 lines, -10 lines 1 comment Download

Messages

Total messages: 13 (8 generated)
ortuno
dpapad: PTAL
3 years, 8 months ago (2017-04-20 01:26:52 UTC) #4
dpapad
LGTM https://codereview.chromium.org/2829783003/diff/1/chrome/test/data/webui/bluetooth_internals_browsertest.js File chrome/test/data/webui/bluetooth_internals_browsertest.js (right): https://codereview.chromium.org/2829783003/diff/1/chrome/test/data/webui/bluetooth_internals_browsertest.js#newcode310 chrome/test/data/webui/bluetooth_internals_browsertest.js:310: TEST_F('BluetoothInternalsTest', 'Startup_BluetoothInternals', FWIW, I am planning to disable ...
3 years, 8 months ago (2017-04-20 01:38:06 UTC) #5
ortuno
On 2017/04/20 at 01:38:06, dpapad wrote: > LGTM > > https://codereview.chromium.org/2829783003/diff/1/chrome/test/data/webui/bluetooth_internals_browsertest.js > File chrome/test/data/webui/bluetooth_internals_browsertest.js (right): ...
3 years, 8 months ago (2017-04-20 01:40:32 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829783003/1
3 years, 8 months ago (2017-04-20 01:40:44 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 03:12:25 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d8adf4fbe2475512e37844327901...

Powered by Google App Engine
This is Rietveld 408576698