Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(787)

Issue 2690303003: MD Settings: Disable tests for ASAN bots. (Closed)

Created:
3 years, 10 months ago by dpapad
Modified:
3 years, 10 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, stevenjb
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Disable tests for ASAN bots. JS unit tests do not exercise the C++ handlers, so there is no value in running them in ASAN bots. BUG=691965 Review-Url: https://codereview.chromium.org/2690303003 Cr-Commit-Position: refs/heads/master@{#450632} Committed: https://chromium.googlesource.com/chromium/src/+/e7034ccc67cda1cb860cf0fa236c1fad2ad8409a

Patch Set 1 #

Patch Set 2 : Fix ChromeOS. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -29 lines) Patch
M chrome/test/BUILD.gn View 1 1 chunk +27 lines, -21 lines 0 comments Download
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 1 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 19 (15 generated)
dpapad
3 years, 10 months ago (2017-02-15 01:48:08 UTC) #13
Dan Beam
lgtm
3 years, 10 months ago (2017-02-15 03:38:00 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2690303003/40001
3 years, 10 months ago (2017-02-15 07:47:57 UTC) #16
commit-bot: I haz the power
3 years, 10 months ago (2017-02-15 07:54:51 UTC) #19
Message was sent while issue was closed.
Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e7034ccc67cda1cb860cf0fa236c...

Powered by Google App Engine
This is Rietveld 408576698