Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3095)

Unified Diff: chrome/test/data/webui/bluetooth_internals_browsertest.js

Issue 2829783003: bluetooth-internals: Fix flaky test (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/bluetooth_internals_browsertest.js
diff --git a/chrome/test/data/webui/bluetooth_internals_browsertest.js b/chrome/test/data/webui/bluetooth_internals_browsertest.js
index cef7a06f633eb004ea3ad238b27e29ea55c1bec2..a7ab6ad95ddd5610298db8cfd455771ba9d12f30 100644
--- a/chrome/test/data/webui/bluetooth_internals_browsertest.js
+++ b/chrome/test/data/webui/bluetooth_internals_browsertest.js
@@ -307,15 +307,7 @@ BluetoothInternalsTest.prototype = {
},
};
-// Flaky on Debug and ASAN. See crbug.com/707530
-GEN('#if !defined(NDEBUG) || defined(ADDRESS_SANITIZER)');
-GEN('#define MAYBE_Startup_BluetoothInternals ' +
- 'DISABLED_Startup_BluetoothInternals');
-GEN('#else');
-GEN('#define MAYBE_Startup_BluetoothInternals Startup_BluetoothInternals');
-GEN('#endif');
-
-TEST_F('BluetoothInternalsTest', 'MAYBE_Startup_BluetoothInternals',
+TEST_F('BluetoothInternalsTest', 'Startup_BluetoothInternals',
dpapad 2017/04/20 01:38:06 FWIW, I am planning to disable all WebUI tests in
function() {
/** @const */ var PageManager = cr.ui.pageManager.PageManager;
@@ -677,7 +669,7 @@ TEST_F('BluetoothInternalsTest', 'MAYBE_Startup_BluetoothInternals',
whenSnackbarShows(snackbar3).then(next);
snackbar3.addEventListener('dismissed', next);
- whenSnackbarShows(snackbar1).then(function() {
+ return whenSnackbarShows(snackbar1).then(function() {
return snackbar.Snackbar.dismiss(true);
}).then(function() {
expectEquals(0, snackbar.Snackbar.queue_.length);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698