Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2829043004: Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::Modify (Closed)

Created:
3 years, 8 months ago by Xiaocheng
Modified:
3 years, 8 months ago
Reviewers:
yosin_UTC9
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::Modify This patch prunes the deprecated function from both overloads of FrameSelection::Modify to improve code health. BUG=698633 TEST=n/a; no behaviorial change Review-Url: https://codereview.chromium.org/2829043004 Cr-Commit-Position: refs/heads/master@{#466915} Committed: https://chromium.googlesource.com/chromium/src/+/ce75e0da74bdaf313e73520f040ff2bd446d2d7a

Patch Set 1 #

Patch Set 2 : Mon Apr 24 09:54:21 PDT 2017 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -7 lines) Patch
M third_party/WebKit/Source/core/editing/DOMSelection.cpp View 1 1 chunk +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/FrameSelection.cpp View 1 2 chunks +7 lines, -7 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
Xiaocheng
PTAL.
3 years, 8 months ago (2017-04-24 19:01:32 UTC) #7
yosin_UTC9
lgtm
3 years, 8 months ago (2017-04-25 07:18:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2829043004/20001
3 years, 8 months ago (2017-04-25 07:18:37 UTC) #10
commit-bot: I haz the power
3 years, 8 months ago (2017-04-25 07:23:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/ce75e0da74bdaf313e73520f040f...

Powered by Google App Engine
This is Rietveld 408576698