Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Unified Diff: third_party/WebKit/Source/core/editing/DOMSelection.cpp

Issue 2829043004: Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::Modify (Closed)
Patch Set: Mon Apr 24 09:54:21 PDT 2017 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/DOMSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/DOMSelection.cpp b/third_party/WebKit/Source/core/editing/DOMSelection.cpp
index 07702b4d928d495df4253bb303f5b2e652da7bc2..dc2cf138088c947afc6df4dec7a1e7e13628381e 100644
--- a/third_party/WebKit/Source/core/editing/DOMSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/DOMSelection.cpp
@@ -442,6 +442,10 @@ void DOMSelection::modify(const String& alter_string,
else
return;
+ // TODO(editing-dev): The use of updateStyleAndLayoutIgnorePendingStylesheets
+ // needs to be audited. See http://crbug.com/590369 for more details.
+ GetFrame()->GetDocument()->UpdateStyleAndLayoutIgnorePendingStylesheets();
+
Element* focused_element = GetFrame()->GetDocument()->FocusedElement();
GetFrame()->Selection().Modify(alter, direction, granularity);
if (GetFrame() && GetFrame()->GetDocument() &&
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698