Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.cpp

Issue 2829043004: Prune ComputeVisibleSelectionInDOMTreeDeprecated from FrameSelection::Modify (Closed)
Patch Set: Mon Apr 24 09:54:21 PDT 2017 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/editing/DOMSelection.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
index cd529ad899a1cdf79ec9ede0af93f9715a900b41..375b644ff4642bcac14b21b0b3eb9adf95053efb 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
@@ -377,15 +377,15 @@ bool FrameSelection::Modify(EAlteration alter,
SelectionDirection direction,
TextGranularity granularity,
EUserTriggered user_triggered) {
- SelectionModifier selection_modifier(
- *GetFrame(), ComputeVisibleSelectionInDOMTreeDeprecated(),
- x_pos_for_vertical_arrow_navigation_);
+ SelectionModifier selection_modifier(*GetFrame(),
+ ComputeVisibleSelectionInDOMTree(),
+ x_pos_for_vertical_arrow_navigation_);
const bool modified =
selection_modifier.Modify(alter, direction, granularity);
if (user_triggered == kUserTriggered &&
selection_modifier.Selection().IsRange() &&
- ComputeVisibleSelectionInDOMTreeDeprecated().IsCaret() &&
- DispatchSelectStart(ComputeVisibleSelectionInDOMTreeDeprecated()) !=
+ ComputeVisibleSelectionInDOMTree().IsCaret() &&
+ DispatchSelectStart(ComputeVisibleSelectionInDOMTree()) !=
DispatchEventResult::kNotCanceled) {
return false;
}
@@ -420,8 +420,8 @@ bool FrameSelection::Modify(EAlteration alter,
bool FrameSelection::Modify(EAlteration alter,
unsigned vertical_distance,
VerticalDirection direction) {
- SelectionModifier selection_modifier(
- *GetFrame(), ComputeVisibleSelectionInDOMTreeDeprecated());
+ SelectionModifier selection_modifier(*GetFrame(),
+ ComputeVisibleSelectionInDOMTree());
if (!selection_modifier.ModifyWithPageGranularity(alter, vertical_distance,
direction)) {
return false;
« no previous file with comments | « third_party/WebKit/Source/core/editing/DOMSelection.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698