Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2828893002: [Ash] Remove |highlight| field from NetworkInfo struct (Closed)

Created:
3 years, 8 months ago by tdanderson
Modified:
3 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, kalyank, sadrul
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

[Ash] Remove |highlight| field from NetworkInfo struct Remove the now-unused |highlight| field from the NetworkInfo struct. BUG=708190 TEST=manual Review-Url: https://codereview.chromium.org/2828893002 Cr-Commit-Position: refs/heads/master@{#466012} Committed: https://chromium.googlesource.com/chromium/src/+/bba159d855e4880a71fb5e3cdfb3b5e9c81608a1

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -10 lines) Patch
M ash/system/network/network_info.h View 2 chunks +0 lines, -2 lines 0 comments Download
M ash/system/network/network_info.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M ash/system/network/network_list.cc View 2 chunks +0 lines, -3 lines 1 comment Download

Messages

Total messages: 12 (8 generated)
tdanderson
Evan, can you please take a look? https://codereview.chromium.org/2828893002/diff/1/ash/system/network/network_list.cc File ash/system/network/network_list.cc (left): https://codereview.chromium.org/2828893002/diff/1/ash/system/network/network_list.cc#oldcode374 ash/system/network/network_list.cc:374: if (network1->highlight ...
3 years, 8 months ago (2017-04-19 20:45:59 UTC) #4
Evan Stade
lgtm
3 years, 8 months ago (2017-04-19 22:02:57 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2828893002/1
3 years, 8 months ago (2017-04-20 15:11:12 UTC) #9
commit-bot: I haz the power
3 years, 8 months ago (2017-04-20 15:17:12 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/bba159d855e4880a71fb5e3cdfb3...

Powered by Google App Engine
This is Rietveld 408576698